From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: POM Xtables??? Date: Tue, 01 Jul 2008 13:57:40 +0200 Message-ID: <486A1BB4.10905@trash.net> References: <935fab200806271054oa7c340evbf465b7a9984498b@mail.gmail.com> <4866F152.7030109@riverviewtech.net> <935fab200806300904rc7dc7b2kf58ab7893c3ef20a@mail.gmail.com> <486907EA.60105@trash.net> <48694787.3080906@trash.net> <4869FCE7.9000404@trash.net> <486A1865.40106@trash.net> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Jan Engelhardt Cc: Jozsef Kadlecsik , Dave , netfilter@vger.kernel.org, Netfilter Development Mailinglist Added netfilter-devel to CC. Jan Engelhardt wrote: > On Tuesday 2008-07-01 13:43, Patrick McHardy wrote: >>> You only added the nfmark, and it is printed unconditionally at that, >>> the latter of which I do not see as thrilling. Seems like it is time >>> for a new revision? Also I think the two modules should be unified >>> first. >> It doesn't need a new revision, it doesn't affect the userspace >> API in any way. As for the argument of parsers that might not >> handle this: any parser needs to expect new things to be added >> at the end of the line, otherwise its giving us no possibility >> of ever extending the output, which is not reasonable. >> > That is why LOGMARK has been LOGMARK so far, where the (undocumented) > requirement is that parsers have to split at whitespace and may not > assume any particular order of fields. This allows to selectively log > things by means of flags passed in from userspace and thus sparing > syslog from being spammed with unwanted fields. Spammed with unwanted fields in a huge exaggeration. And nobody sane is using LOG for anything but debugging anyway due to the unreliable nature of the ringbuffer and the huge slowdown this might cause when using serial console. > So the only way is to introduce a LOG2 target? Only way for what? As I stated, you're free to add new fields at the end.