From: Eric Dumazet <eric.dumazet@gmail.com>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: David Miller <davem@davemloft.net>,
kdakhane@gmail.com, netdev@vger.kernel.org,
netfilter@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] tcp: connect() race with timewait reuse
Date: Thu, 03 Dec 2009 07:44:53 +0100 [thread overview]
Message-ID: <4B175E65.3070905@gmail.com> (raw)
In-Reply-To: <20091202221552.GA17579@ioremap.net>
Evgeniy Polyakov a écrit :
> Hi.
>
> Looks very good, thanks Eric, I have one question.
>
> On Wed, Dec 02, 2009 at 04:08:59PM +0100, Eric Dumazet (eric.dumazet@gmail.com) wrote:
>> +
>> +/*
>> + * unhash a timewait socket from established hash
>> + * lock must be hold by caller
>> + */
>> +void inet_twsk_unhash(struct inet_timewait_sock *tw)
>> +{
>> + if (hlist_nulls_unhashed(&tw->tw_node))
>> + return;
>> +
>> + hlist_nulls_del_rcu(&tw->tw_node);
>> + sk_nulls_node_init(&tw->tw_node);
>> + inet_twsk_put(tw);
>
> Is it safe to call in locked context? inet_twsk_put() schedules
> preemption, also I did not check what tw destructor does.
>
You are probably right, we could defer the inet_twsk_put(tw) out of locked
section, you or I will submit another patch to correct this.
Thanks !
next prev parent reply other threads:[~2009-12-03 6:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 2:02 soft lockup in inet_csk_get_port kapil dakhane
2009-12-01 6:10 ` Eric Dumazet
2009-12-01 15:00 ` [PATCH] tcp: Fix a connect() race with timewait sockets Eric Dumazet
2009-12-02 8:59 ` David Miller
2009-12-02 9:23 ` Eric Dumazet
2009-12-02 10:33 ` Eric Dumazet
2009-12-02 11:32 ` Evgeniy Polyakov
2009-12-02 19:18 ` kapil dakhane
2009-12-03 2:43 ` kapil dakhane
2009-12-03 10:49 ` [PATCH] tcp: fix a timewait refcnt race Eric Dumazet
2009-12-04 0:19 ` David Miller
2009-12-04 3:20 ` kapil dakhane
2009-12-04 6:29 ` Eric Dumazet
2009-12-04 6:39 ` David Miller
2009-12-02 15:08 ` [PATCH net-next-2.6] tcp: connect() race with timewait reuse Eric Dumazet
2009-12-02 22:15 ` Evgeniy Polyakov
2009-12-03 6:44 ` Eric Dumazet [this message]
2009-12-03 8:31 ` Eric Dumazet
2009-12-03 23:22 ` Evgeniy Polyakov
2009-12-04 0:18 ` David Miller
2009-12-02 16:05 ` [PATCH] tcp: Fix a connect() race with timewait sockets Ashwani Wason
2009-12-03 6:38 ` David Miller
2009-12-04 13:45 ` [PATCH 0/2] tcp: Fix connect() races " Eric Dumazet
2009-12-04 13:46 ` [PATCH 1/2] tcp: Fix a connect() race " Eric Dumazet
2009-12-05 21:21 ` Evgeniy Polyakov
2009-12-07 9:59 ` [PATCH] tcp: documents timewait refcnt tricks Eric Dumazet
2009-12-07 16:06 ` Randy Dunlap
2009-12-09 4:20 ` David Miller
2009-12-09 4:18 ` [PATCH 1/2] tcp: Fix a connect() race with timewait sockets David Miller
2009-12-04 13:47 ` [PATCH 2/2] " Eric Dumazet
2009-12-09 4:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B175E65.3070905@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=kdakhane@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).