From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] netfilter: don't xt_jumpstack_alloc twice in xt_register_table Date: Mon, 31 May 2010 16:37:17 +0200 Message-ID: <4C03C99D.5010904@trash.net> References: <1275303998-2435-1-git-send-email-dfeng@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Jan Engelhardt Cc: Xiaotian Feng , netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Andrew Morton , Rusty Russell , Alexey Dobriyan Jan Engelhardt wrote: > On Monday 2010-05-31 13:51, Jan Engelhardt wrote: >> On Monday 2010-05-31 13:06, Xiaotian Feng wrote: >> >>> In xt_register_table, xt_jumpstack_alloc is called first, later >>> xt_replace_table is used. But in xt_replace_table, xt_jumpstack_alloc >>> will be used again. Then the memory allocated by previous xt_jumpstack_alloc >>> will be leaked. We can simply remove the previous xt_jumpstack_alloc because >>> there aren't any users of newinfo between xt_jumpstack_alloc and >>> xt_replace_table. >> Indeed that seems to be so. > > Acked-By: Jan Engelhardt Applied, thanks.