From: Pablo Neira Ayuso <pablo@netfilter.org>
To: David Favro <netfilter@meta-dynamic.com>
Cc: netfilter@vger.kernel.org
Subject: Re: [PATCH libnetfilter_queue 1/3] Non-modified payload arguments are pointer-to-const.
Date: Thu, 10 Jun 2010 15:06:00 +0200 [thread overview]
Message-ID: <4C10E338.1060406@netfilter.org> (raw)
In-Reply-To: <1275720020-14058-1-git-send-email-netfilter@meta-dynamic.com>
David Favro wrote:
> The payload parameters to nfq_set_verdict(), nfq_set_verdict2(), and
> nfq_set_verdict_mark() are not modified by those functions, and
> therefore should have datatype pointer-to-const. This both causes the
> source-code to more effectively represent what is the purpose of the
> parameter, and eliminates the need to cast away const-ness when calling
> the functions with compilers that enforce strict casting. All existing
> calling code should not need modification as pointer-to-X automatically
> converts to pointer-to-const-X.
This doesn't seem to break ABI so I'm fine with them. Applied, thanks David.
prev parent reply other threads:[~2010-06-10 13:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 6:40 [PATCH libnetfilter_queue 1/3] Non-modified payload arguments are pointer-to-const David Favro
2010-06-05 6:40 ` [PATCH libnetfilter_queue 2/3] Payload buffer datatypes are consistent David Favro
2010-06-10 13:06 ` Pablo Neira Ayuso
2010-06-05 6:40 ` [PATCH libnetfilter_queue 3/3] Added .gitignore for base directory David Favro
2010-06-10 13:06 ` Pablo Neira Ayuso
2010-06-10 13:06 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C10E338.1060406@netfilter.org \
--to=pablo@netfilter.org \
--cc=netfilter@meta-dynamic.com \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).