Linux Netfilter discussions
 help / color / mirror / Atom feed
From: Mr Dash Four <mr.dash.four@googlemail.com>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: "'netfilter@vger.kernel.org'" <netfilter@vger.kernel.org>
Subject: Re: xtables 1.31 compilation errors
Date: Sat, 11 Dec 2010 01:47:19 +0000	[thread overview]
Message-ID: <4D02D827.5090208@googlemail.com> (raw)
In-Reply-To: <4D02D510.9050700@googlemail.com>


> Further to the above: The 'problematic' line, which SHOULD be included 
> in libxt_gradm.c is:
> #include "compat_user.h" (it actually states in the header file 
> "linux-glibc-devel 2.6.34 header screwup", so at least someone admits 
> to a screw up for once!)
>
> With this however, the problems are NOT fixed, I am getting this 
> further down the line:
>
> ipset_iphash.c: In function ‘iphash_create_init’:
> ipset_iphash.c:42: error: ‘IP_NF_SET_HASHSIZE’ undeclared (first use 
> in this function)
> ipset_iphash.c:42: error: (Each undeclared identifier is reported only 
> once
> ipset_iphash.c:42: error: for each function it appears in.)
> make[5]: *** [libipset_iphash.oo] Error 1
> make[5]: *** Waiting for unfinished jobs....
> make[5]: Leaving directory 
> `/home/zeek/rpmbuild/BUILD/xtables-addons-1.31/extensions/ipset'
> make[4]: *** [user-all-local] Error 2
> make[4]: *** Waiting for unfinished jobs....
> make[4]: Leaving directory 
> `/home/zeek/rpmbuild/BUILD/xtables-addons-1.31/extensions/ipset'
...Also, IP_NF_SET_HASHSIZE is in ipset_ipportiphash.c, 
ipset_ipporthash.c and ipset_nethash.c, in neither of which 
IP_NF_SET_HASHSIZE is defined, apparently!

There is a definition of CONFIG_IP_NF_SET_HASHSIZE in ip_set.h which is 
set to 1024.

In 1.30 the value of 1024 is directly used, instead of 
IP_NF_SET_HASHSIZE (which SHOULD have been CONFIG_IP_NF_SET_HASHSIZE!), 
so someone (Jozsef?) needs to fix this.

I am amazed nobody checks these things - how do you compile this code 
people?

  reply	other threads:[~2010-12-11  1:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-11  0:41 xtables 1.31 compilation errors Mr Dash Four
2010-12-11  0:54 ` Jan Engelhardt
2010-12-11  1:02   ` Mr Dash Four
2010-12-11  1:34     ` Mr Dash Four
2010-12-11  1:47       ` Mr Dash Four [this message]
2010-12-11  3:34         ` Jan Engelhardt
     [not found]           ` <4D03806F.6050107@googlemail.com>
     [not found]             ` <alpine.LNX.2.01.1012111737310.17765@obet.zrqbmnf.qr>
2010-12-12 14:50               ` Mr Dash Four
2010-12-11  3:07       ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D02D827.5090208@googlemail.com \
    --to=mr.dash.four@googlemail.com \
    --cc=jengelh@medozas.de \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox