netfilter.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mr Dash Four <mr.dash.four@googlemail.com>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: "netfilter@vger.kernel.org" <netfilter@vger.kernel.org>
Subject: Re: ipset v6.latest bugs?
Date: Wed, 27 Apr 2011 13:00:57 +0100	[thread overview]
Message-ID: <4DB80579.7090208@googlemail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1104270905450.5222@blackhole.kfki.hu>


>> 2. Take a note when I try to add 4608 elements to the test set - I did that 3
>> times with completely different results - it seems that ipset triggers an
>> error when it feels like it.
>>     
>
> The hashes are created with a random hash key calculation parameter: if 
> the hash is lucky enough, you can stuff the data into it without reaching 
> the clashing limit and without the need to resize the hash.
>   
I see, so the error is triggered at random because the randomly 
generated hash sometimes is able to "stuff the data", as you put it, 
without reaching the limit, but sometimes it doesn't and this, then, 
triggers the error, is that correct?

>> 3. Following on from the previous point, when I try to add more elements than
>> the established "error threshold" in point 2 above, I also get mixed results
>> (attempting to add 4864 elements gives me 2 successes and 2 failures after 4
>> attempts made when I re-created the test set from scratch).
>>     
>
> The same as above: if the clash limit is not reached, the hash happily 
> can accept more data. If it's reached, resizing is triggered which is 
> successfully done, but adding elements starts again with the already added 
> element. That needs to be fixed.
>   
I think I understand it now, thanks for the explanation. I hope that you 
would be able to fix this bug.

On a separate note, two days ago I was finally able to split ipset from 
xtables-addons and build it as a separate package (i.e. construct a 
.spec file, then build and install rpm based on that) while building 
only the userspace part (assuming the kernel part will stay with the 
kernel). This is by no means finished (there are some things still left 
to be ironed out - kernel modules dependency check, changelog history to 
be added etc), but I thought you may be interested in this.

If so, let me know and I'll send it to you (the important part is the 
.spec file and a separate patch which removes the build routines for the 
kernel modules).

I am in a process of doing the same with version 4.5 of ipset (I was 
able to successfully build the .35-88 version of the kernel with ipset 
4.5 kernel modules happily integrated into it yesterday), even though 
ipset 4.5 does not have pkgconfig files I intend to create these - 
hopefully today.

  reply	other threads:[~2011-04-27 12:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-25 11:55 ipset v6.latest bugs? Mr Dash Four
2011-04-25 20:03 ` Jozsef Kadlecsik
2011-04-25 20:36   ` Mr Dash Four
2011-04-25 21:51     ` Jozsef Kadlecsik
2011-04-26  0:38       ` Mr Dash Four
2011-04-26 13:57         ` Jozsef Kadlecsik
2011-04-26 15:04           ` Mr Dash Four
2011-04-26 23:18             ` Mr Dash Four
2011-04-27  7:15               ` Jozsef Kadlecsik
2011-04-27 12:00                 ` Mr Dash Four [this message]
2011-04-27 21:27                   ` Jozsef Kadlecsik
2011-04-27 21:40                     ` Mr Dash Four

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB80579.7090208@googlemail.com \
    --to=mr.dash.four@googlemail.com \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).