netfilter.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mr Dash Four <mr.dash.four@googlemail.com>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netfilter@vger.kernel.org
Subject: Re: [ANNOUNCE] ipset 6.5 released
Date: Wed, 18 May 2011 11:59:00 +0100	[thread overview]
Message-ID: <4DD3A674.2050502@googlemail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1105180948160.4117@blackhole.kfki.hu>


> The latter itself exhausts the maximal number of elements in the set, so 
> the error message is normal.
>   
Is this a constraint coming from the "maxelem" value or the hash size? 
Could this be corrected by increasing either of these?

>> The way I look at it, the "old" iptree(map) type sets should be converted to
>> hash:net, not hash:ip to avoid this error.
>>     
>
> That's too late, I can't change the mapping from hash:ip to hash:net.
> (And if the mapping pointed to hash:net, you were surprised then that 
> after adding say 192.68.0.0/24 to the set, you couldn't delete 192.68.0.1 
> from it. :-)
>   
Nope. I am aware that deleting elements in 6.x should be done on the 
whole range when added, not just a single ip address (I am now clear as 
to why that happens and I think it makes sense in the way it is designed).

If you are to provide "backward" compatibility (or compatibility of any 
sort) with iptree(map) sets then you should make sure that at least 
members of that type of set could, at least, register without problem 
within the new set to which iptree(map) is converted. It seems to me 
that is not the case - with 6.5 at least. If it is difficult to maintain 
such compatibility you could do what you have already done with the 
"bindings" in previous versions of ipset - just drop it and ask users to 
switch to the new type. Frankly, it is not that difficult to switch over 
to the new type if one is aware of the implications, so it wouldn't be a 
big shock.


  reply	other threads:[~2011-05-18 10:59 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-15 13:50 [ANNOUNCE] ipset 6.5 released Jozsef Kadlecsik
2011-05-16 15:41 ` Mr Dash Four
2011-05-17  7:42   ` Jozsef Kadlecsik
2011-05-17 11:03     ` Mr Dash Four
2011-05-17 11:51       ` Jozsef Kadlecsik
2011-05-17 15:23         ` Mr Dash Four
2011-05-17 18:36           ` Mr Dash Four
2011-05-18  7:54             ` Jozsef Kadlecsik
2011-05-18 10:59               ` Mr Dash Four [this message]
2011-05-18 11:22                 ` Jozsef Kadlecsik
2011-05-21 19:42     ` Mr Dash Four
2011-05-21 19:45       ` Jozsef Kadlecsik
2011-05-21 19:58       ` Jozsef Kadlecsik
2011-05-21 20:11         ` Mr Dash Four
2011-05-21 21:31       ` Jozsef Kadlecsik
2011-05-21 21:33         ` Jan Engelhardt
2011-05-21 21:41           ` Mr Dash Four
2011-05-21 21:52             ` Jan Engelhardt
2011-05-21 23:08               ` Jozsef Kadlecsik
2011-05-22  1:01                 ` Mr Dash Four
2011-05-22 10:05                   ` Jozsef Kadlecsik
2011-05-22 10:36                     ` Jozsef Kadlecsik
2011-05-22 11:44                       ` Mr Dash Four
2011-05-22 11:44                     ` Mr Dash Four
2011-05-22 21:21                       ` Jozsef Kadlecsik
2011-05-22 21:32                         ` Mr Dash Four
2011-05-22 15:00                 ` Jan Engelhardt
2011-05-22 13:57               ` Mr Dash Four
2011-05-22 14:05                 ` Mr Dash Four
2011-05-21 21:51           ` Mr Dash Four
2011-05-21 21:41         ` Mr Dash Four
2011-05-21 22:28           ` Jozsef Kadlecsik
2011-05-21 22:41             ` Jozsef Kadlecsik
2011-05-21 22:44               ` Mr Dash Four
2011-05-21 22:42             ` Mr Dash Four
2011-05-22 14:52             ` Mr Dash Four
2011-05-21 22:15 ` Mr Dash Four
2011-05-21 22:31   ` Jozsef Kadlecsik
2011-05-21 22:42     ` Mr Dash Four
2011-05-21 22:49       ` Jozsef Kadlecsik
2011-05-21 22:57         ` Mr Dash Four
2011-05-21 23:25           ` Jozsef Kadlecsik
2011-05-21 23:33             ` Mr Dash Four
2011-05-22  9:56               ` Jozsef Kadlecsik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DD3A674.2050502@googlemail.com \
    --to=mr.dash.four@googlemail.com \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).