From: David Howells <dhowells@redhat.com>
To: Steve French <smfrench@gmail.com>
Cc: dhowells@redhat.com, Steve French <sfrench@samba.org>,
Paulo Alcantara <pc@manguebit.org>,
Shyam Prasad N <sprasad@microsoft.com>,
Stefan Metzmacher <metze@samba.org>, Tom Talpey <tom@talpey.com>,
linux-cifs@vger.kernel.org, netfs@lists.linux.dev,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/9] cifs: Miscellaneous prep patches for rewrite of I/O layer
Date: Tue, 02 Dec 2025 07:15:28 +0000 [thread overview]
Message-ID: <1530645.1764659728@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAH2r5mspiEXcA2pxTfQrWrpZDLEW5YjFJCn0An4OcpEtkJ+B2A@mail.gmail.com>
Steve French <smfrench@gmail.com> wrote:
> The first seven (of the nine you sent recently) applied ok to
> ksmbd-for-next and I can do some testing on them, as we await more
> review and testing of the patches but patch 8 caused a few checkpatch
> warnings (and patch 9 depends on it). Do you want to clean it up?
>
>
> ./scripts/checkpatch.pl 9/0008-cifs-Add-a-tracepoint-to-log-EIO-errors.patch
> ERROR: trailing whitespace
> #440: FILE: fs/smb/client/cifssmb.c:1379:
> +^Idefault: $
I can clean this one up.
> ERROR: Macros with complex values should be enclosed in parentheses
> #2069: FILE: fs/smb/client/trace.h:23:
> +#define smb_eio_traces \
> + EM(smb_eio_trace_compress_copy, "compress_copy") \
> + EM(smb_eio_trace_copychunk_inv_rsp, "copychunk_inv_rsp") \
> ...
In this case, checkpatch is wrong. This cannot be enclosed in parentheses as
it will then fail to compile as this is used to generate an enum. If you
compare it to other trace headers (including your own trace.h, you'll see this
sort of construct in a number of places).
David
prev parent reply other threads:[~2025-12-02 7:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 22:57 [PATCH v6 0/9] cifs: Miscellaneous prep patches for rewrite of I/O layer David Howells
2025-12-01 22:57 ` [PATCH v6 1/9] cifs: Remove the RFC1002 header from smb_hdr David Howells
2025-12-18 12:17 ` Namjae Jeon
2025-12-18 13:36 ` David Howells
2025-12-18 15:17 ` Namjae Jeon
2025-12-01 22:57 ` [PATCH v6 2/9] cifs: Make smb1's SendReceive() wrap cifs_send_recv() David Howells
2025-12-01 22:57 ` [PATCH v6 3/9] cifs: Clean up some places where an extra kvec[] was required for rfc1002 David Howells
2025-12-01 22:57 ` [PATCH v6 4/9] cifs: Replace SendReceiveBlockingLock() with SendReceive() plus flags David Howells
2025-12-01 22:57 ` [PATCH v6 5/9] cifs: Fix specification of function pointers David Howells
2025-12-01 22:57 ` [PATCH v6 6/9] cifs: Remove the server pointer from smb_message David Howells
2025-12-01 22:57 ` [PATCH v6 7/9] cifs: Don't need state locking in smb2_get_mid_entry() David Howells
2025-12-01 22:57 ` [PATCH v6 8/9] cifs: Add a tracepoint to log EIO errors David Howells
2025-12-01 22:57 ` [PATCH v6 9/9] cifs: Do some preparation prior to organising the function declarations David Howells
2025-12-02 1:04 ` [PATCH v6 0/9] cifs: Miscellaneous prep patches for rewrite of I/O layer Steve French
2025-12-02 7:15 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530645.1764659728@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metze@samba.org \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox