From: David Howells <dhowells@redhat.com>
To: Keith Busch <kbusch@kernel.org>
Cc: dhowells@redhat.com, Jens Axboe <axboe@kernel.dk>,
Hannes Reinecke <hare@kernel.org>, Christoph Hellwig <hch@lst.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Paulo Alcantara <pc@manguebit.org>,
netfs@lists.linux.dev, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Fix start and length check added to iov_iter_extract_bvecs()
Date: Wed, 26 Aug 2026 21:23:30 +0100 [thread overview]
Message-ID: <1885163.1787775810@warthog.procyon.org.uk> (raw)
In-Reply-To: <ao9CvZDRChrrxyCj@kbusch-mbp>
Keith Busch <kbusch@kernel.org> wrote:
> + if (likely(iter_is_ubuf(iter) ||
> + iter_is_iovec(iter) ||
> + iov_iter_is_kvec(iter))) {
I wonder if it's worth making an exception for ITER_KVEC. I know the structs
align, as it were, but do we use ITER_KVEC often enough?
Anyway, it seems to work, so you can add:
Reviewed-by: David Howells <dhowells@redhat.com>
if you want to submit the patch yourself.
David
next prev parent reply other threads:[~2026-08-26 20:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 18:18 [PATCH] block: Fix start and length check added to iov_iter_extract_bvecs() David Howells
2026-08-26 18:34 ` Keith Busch
2026-08-26 19:24 ` David Howells
2026-08-26 19:47 ` Keith Busch
2026-08-26 20:23 ` David Howells [this message]
2026-08-26 19:49 ` David Howells
2026-08-26 20:02 ` Keith Busch
2026-08-26 20:46 ` [PATCH v2] " David Howells
2026-08-26 20:52 ` Keith Busch
2026-08-26 20:54 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1885163.1787775810@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=axboe@kernel.dk \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox