From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 053C069E05; Tue, 20 Feb 2024 13:32:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708435924; cv=none; b=eHszwRqhqKzTLrbA1a7GIUuHOdo1uY5HtPTs06Hqs0BWje54iUNT7ez3fdhKAnYij4wdNYr3ygR5XQOYhQu9jeOde9fNZtjD2exWejdFFsfOGvIKmTjYayfWYlwJ5N+yiwFq6UIYm9Sx24Gzs6czc/gt7FthaiKStJXtPfWLGj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708435924; c=relaxed/simple; bh=kSbCNkvZKv7xzsaEeoxDKEEwm8/5FhdatiejKc2BuLY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X/406Q+uawDsH3A5BmKl9aBbuHGcaAt70JqCpsUJNvHslu25JrEKV/6m+tfI+NIsZgJZAIy42KpxpDrTSWLSdFL5llwneZm58gsd5bKX6T9gRmXirD+HHadkQqOdMyl05HqOGvjy/tm4CH++wEn/KKomTw+xfA3wSMQdDrxYg14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YJsUQi5K; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YJsUQi5K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 556E2C433C7; Tue, 20 Feb 2024 13:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708435923; bh=kSbCNkvZKv7xzsaEeoxDKEEwm8/5FhdatiejKc2BuLY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YJsUQi5KCSO8MtsgHZ+Vn/m7BcHINEuYM5ToUiaFq7kh2KQMRPea4IFD5yzNstNiD 1rIrxcgdE21DiDSY+Q2JJxcDATS0zp9n2BOMTPLWHFRlbsXLbHaaqN5dvJRaiDArc7 v/X9MUp8DeIQZnjEpz/WW9n9i2tUrPb1ZFwv+vbErFChi21tJp2tWkJtX7HBup9UZQ IRBcqjs1VlPXekQrY3dUUtseVwFyj5b9J8dvDyM/KdT59kDx5Z9w6ypWLA4FsSESQH 3j7QwtZUDUGkVZR1WWGjNCetelLouTz+eg5OLO2Ij0xwNRIa3n6pZCBufJmoXudWHV 3xQ463OyS0adQ== Date: Tue, 20 Feb 2024 13:31:58 +0000 From: Simon Horman To: David Howells Cc: Steve French , Jeff Layton , Matthew Wilcox , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Christian Brauner , netfs@lists.linux.dev, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Steve French , Shyam Prasad N , Rohith Surabattula Subject: Re: [PATCH v5 09/12] cifs: Cut over to using netfslib Message-ID: <20240220133158.GL40273@kernel.org> References: <20240209105947.GF1516992@kernel.org> <20240205225726.3104808-1-dhowells@redhat.com> <20240205225726.3104808-10-dhowells@redhat.com> <140602.1708355444@warthog.procyon.org.uk> Precedence: bulk X-Mailing-List: netfs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <140602.1708355444@warthog.procyon.org.uk> On Mon, Feb 19, 2024 at 03:10:44PM +0000, David Howells wrote: > Simon Horman wrote: > > > > /* Functions related to files and directories */ > > > +extern const struct netfs_request_ops cifs_req_ops; > > > extern const struct file_operations cifs_file_ops; > > > extern const struct file_operations cifs_file_direct_ops; /* if directio mnt */ > > > extern const struct file_operations cifs_file_strict_ops; /* if strictio mnt */ > > > > Nit: this hunk would probably be better placed in the > > patch at adds cifs_req_ops to fs/smb/client/file.c > > I'm not sure I understand what you mean. Is there a bit missing between "at" > and "adds" in that? Sorry, "patch that adds". What I meant is, the declaration of cifs_req_ops and it's definition seem to appear in different patches of this series. And it might make sense if they were both in the same patch. But given that both are present by the end of the series it is more cosmetic than anything else.