Linux network filesystem support library
 help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>, netfs@lists.linux.dev
Subject: [PATCH 1/2] netfs: Remove call to folio_index()
Date: Thu, 25 Jul 2024 23:02:36 +0100	[thread overview]
Message-ID: <20240725220239.2247246-1-willy@infradead.org> (raw)

Calling folio_index() is pointless overhead; directly dereferencing
folio->index is fine.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 include/trace/events/netfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/events/netfs.h b/include/trace/events/netfs.h
index da23484268df..5f199e01e888 100644
--- a/include/trace/events/netfs.h
+++ b/include/trace/events/netfs.h
@@ -420,7 +420,7 @@ TRACE_EVENT(netfs_folio,
 	    TP_fast_assign(
 		    __entry->ino = folio->mapping->host->i_ino;
 		    __entry->why = why;
-		    __entry->index = folio_index(folio);
+		    __entry->index = folio->index;
 		    __entry->nr = folio_nr_pages(folio);
 			   ),
 
-- 
2.43.0


             reply	other threads:[~2024-07-25 22:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-25 22:02 Matthew Wilcox (Oracle) [this message]
2024-07-25 22:02 ` [PATCH 2/2] netfs: Remove unnecessary references to pages Matthew Wilcox (Oracle)
2024-07-26 15:18 ` [PATCH 1/2] netfs: Remove call to folio_index() Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240725220239.2247246-1-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=dhowells@redhat.com \
    --cc=netfs@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox