From: Christian Brauner <brauner@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: Christian Brauner <brauner@kernel.org>,
Jeff Layton <jlayton@kernel.org>,
netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfs: Fix missing wakeup after issuing writes
Date: Wed, 2 Oct 2024 16:56:30 +0200 [thread overview]
Message-ID: <20241002-sendung-rausch-9c589b8d09e8@brauner> (raw)
In-Reply-To: <3317784.1727880350@warthog.procyon.org.uk>
On Wed, 02 Oct 2024 15:45:50 +0100, David Howells wrote:
> After dividing up a proposed write into subrequests, netfslib sets
> NETFS_RREQ_ALL_QUEUED to indicate to the collector that it can move on to
> the final cleanup once it has emptied the subrequest queues.
>
> Now, whilst the collector will normally end up running at least once after
> this bit is set just because it takes a while to process all the write
> subrequests before the collector runs out of subrequests, there exists the
> possibility that the issuing thread will be forced to sleep and the
> collector thread will clean up all the subrequests before ALL_QUEUED gets
> set.
>
> [...]
Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes
[1/1] netfs: Fix missing wakeup after issuing writes
https://git.kernel.org/vfs/vfs/c/1ca4169c391c
prev parent reply other threads:[~2024-10-02 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 14:45 [PATCH] netfs: Fix missing wakeup after issuing writes David Howells
2024-10-02 14:56 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002-sendung-rausch-9c589b8d09e8@brauner \
--to=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox