netfs.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>,
	Steve French <smfrench@gmail.com>,
	Matthew Wilcox <willy@infradead.org>
Cc: David Howells <dhowells@redhat.com>,
	Jeff Layton <jlayton@kernel.org>,
	Gao Xiang <hsiangkao@linux.alibaba.com>,
	Dominique Martinet <asmadeus@codewreck.org>,
	Marc Dionne <marc.dionne@auristor.com>,
	Paulo Alcantara <pc@manguebit.com>,
	Shyam Prasad N <sprasad@microsoft.com>,
	Tom Talpey <tom@talpey.com>,
	Eric Van Hensbergen <ericvh@kernel.org>,
	Ilya Dryomov <idryomov@gmail.com>,
	netfs@lists.linux.dev, linux-afs@lists.infradead.org,
	linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
	ceph-devel@vger.kernel.org, v9fs@lists.linux.dev,
	linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v4 22/33] afs: Make afs_init_request() get a key if not given a file
Date: Fri,  8 Nov 2024 17:32:23 +0000	[thread overview]
Message-ID: <20241108173236.1382366-23-dhowells@redhat.com> (raw)
In-Reply-To: <20241108173236.1382366-1-dhowells@redhat.com>

In a future patch, AFS directory caching will go through netfslib and this
will involve, at times, running on behalf of ->lookup(), which doesn't
provide us with a file from which we can get an authentication key.

If a file isn't provided, make afs_init_request() get a key from the
process's keyrings instead when setting up a read.

Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
---
 fs/afs/file.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/fs/afs/file.c b/fs/afs/file.c
index f717168da4ab..a9d98d18407c 100644
--- a/fs/afs/file.c
+++ b/fs/afs/file.c
@@ -372,10 +372,26 @@ static int afs_symlink_read_folio(struct file *file, struct folio *folio)
 
 static int afs_init_request(struct netfs_io_request *rreq, struct file *file)
 {
+	struct afs_vnode *vnode = AFS_FS_I(rreq->inode);
+
 	if (file)
 		rreq->netfs_priv = key_get(afs_file_key(file));
 	rreq->rsize = 256 * 1024;
 	rreq->wsize = 256 * 1024 * 1024;
+
+	switch (rreq->origin) {
+	case NETFS_READ_SINGLE:
+		if (!file) {
+			struct key *key = afs_request_key(vnode->volume->cell);
+
+			if (IS_ERR(key))
+				return PTR_ERR(key);
+			rreq->netfs_priv = key;
+		}
+		break;
+	default:
+		break;
+	}
 	return 0;
 }
 


  parent reply	other threads:[~2024-11-08 17:35 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-08 17:32 [PATCH v4 00/33] netfs: Read performance improvements and "single-blob" support David Howells
2024-11-08 17:32 ` [PATCH v4 01/33] kheaders: Ignore silly-rename files David Howells
2024-11-08 17:32 ` [PATCH v4 02/33] netfs: Remove call to folio_index() David Howells
2024-11-08 17:32 ` [PATCH v4 03/33] netfs: Fix a few minor bugs in netfs_page_mkwrite() David Howells
2024-11-08 17:32 ` [PATCH v4 04/33] netfs: Remove unnecessary references to pages David Howells
2024-11-08 17:32 ` [PATCH v4 05/33] netfs: Use a folio_queue allocation and free functions David Howells
2024-11-08 17:32 ` [PATCH v4 06/33] netfs: Add a tracepoint to log the lifespan of folio_queue structs David Howells
2024-11-08 17:32 ` [PATCH v4 07/33] netfs: Abstract out a rolling folio buffer implementation David Howells
2024-11-15 20:01   ` Kees Bakker
2024-11-18 16:39   ` David Howells
2024-11-08 17:32 ` [PATCH v4 08/33] netfs: Make netfs_advance_write() return size_t David Howells
2024-11-08 17:32 ` [PATCH v4 09/33] netfs: Split retry code out of fs/netfs/write_collect.c David Howells
2024-11-08 17:32 ` [PATCH v4 10/33] netfs: Drop the error arg from netfs_read_subreq_terminated() David Howells
2024-11-08 17:32 ` [PATCH v4 11/33] netfs: Drop the was_async " David Howells
2024-11-08 17:32 ` [PATCH v4 12/33] netfs: Don't use bh spinlock David Howells
2024-11-08 17:32 ` [PATCH v4 13/33] afs: Don't use mutex for I/O operation lock David Howells
2024-11-08 17:32 ` [PATCH v4 14/33] afs: Fix EEXIST error returned from afs_rmdir() to be ENOTEMPTY David Howells
2024-11-08 17:32 ` [PATCH v4 15/33] afs: Fix directory format encoding struct David Howells
2024-11-08 17:32 ` [PATCH v4 16/33] netfs: Remove some extraneous directory invalidations David Howells
2024-11-08 17:32 ` [PATCH v4 17/33] cachefiles: Add some subrequest tracepoints David Howells
2024-11-08 17:32 ` [PATCH v4 18/33] cachefiles: Add auxiliary data trace David Howells
2024-11-08 17:32 ` [PATCH v4 19/33] afs: Add more tracepoints to do with tracking validity David Howells
2024-11-08 17:32 ` [PATCH v4 20/33] netfs: Add functions to build/clean a buffer in a folio_queue David Howells
2024-11-08 17:32 ` [PATCH v4 21/33] netfs: Add support for caching single monolithic objects such as AFS dirs David Howells
2024-11-08 17:32 ` David Howells [this message]
2024-11-08 17:32 ` [PATCH v4 23/33] afs: Use netfslib for directories David Howells
2024-11-15 20:32   ` Kees Bakker
2024-11-18 16:35   ` David Howells
2024-11-08 17:32 ` [PATCH v4 24/33] afs: Use netfslib for symlinks, allowing them to be cached David Howells
2024-11-08 17:32 ` [PATCH v4 25/33] afs: Eliminate afs_read David Howells
2024-11-08 17:32 ` [PATCH v4 26/33] afs: Fix cleanup of immediately failed async calls David Howells
2024-11-08 17:32 ` [PATCH v4 27/33] afs: Make {Y,}FS.FetchData an asynchronous operation David Howells
2024-11-08 17:32 ` [PATCH v4 28/33] netfs: Change the read result collector to only use one work item David Howells
2024-11-14 16:39   ` Nathan Chancellor
2024-11-18 17:20   ` David Howells
2024-11-08 17:32 ` [PATCH v4 29/33] afs: Make afs_mkdir() locally initialise a new directory's content David Howells
2024-11-08 17:32 ` [PATCH v4 30/33] afs: Use the contained hashtable to search a directory David Howells
2024-11-08 17:32 ` [PATCH v4 31/33] afs: Locally initialise the contents of a new symlink on creation David Howells
2024-11-08 17:32 ` [PATCH v4 32/33] afs: Add a tracepoint for afs_read_receive() David Howells
2024-11-08 17:32 ` [PATCH v4 33/33] netfs: Report on NULL folioq in netfs_writeback_unlock_folios() David Howells
2024-11-11  9:12 ` [PATCH v4 00/33] netfs: Read performance improvements and "single-blob" support Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241108173236.1382366-23-dhowells@redhat.com \
    --to=dhowells@redhat.com \
    --cc=asmadeus@codewreck.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=christian@brauner.io \
    --cc=ericvh@kernel.org \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=idryomov@gmail.com \
    --cc=jlayton@kernel.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=marc.dionne@auristor.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfs@lists.linux.dev \
    --cc=pc@manguebit.com \
    --cc=smfrench@gmail.com \
    --cc=sprasad@microsoft.com \
    --cc=tom@talpey.com \
    --cc=v9fs@lists.linux.dev \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).