From: Christian Brauner <brauner@kernel.org>
To: David Howells <dhowells@redhat.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Cc: Christian Brauner <brauner@kernel.org>,
Jeff Layton <jlayton@kernel.org>,
netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] netfs: silence an uninitialized variable warning
Date: Wed, 20 Nov 2024 09:28:20 +0100 [thread overview]
Message-ID: <20241120-lageplan-kneifen-e124b37dee93@brauner> (raw)
In-Reply-To: <867904ba-85fe-4766-91cb-3c8ce0703c1e@stanley.mountain>
On Mon, 18 Nov 2024 09:08:19 +0300, Dan Carpenter wrote:
> Smatch complains that "ret" is uninitialized on the success path if we
> don't enter the nested loop at the end of the function. In real life we
> will enter that loop so "ret" will be zero.
>
> Generally, I don't endorse silencing static checker warnings but in this
> case, I think it make sense.
>
> [...]
Applied to the vfs-6.14.netfs branch of the vfs/vfs.git tree.
Patches in the vfs-6.14.netfs branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.14.netfs
[1/1] netfs: silence an uninitialized variable warning
https://git.kernel.org/vfs/vfs/c/574cb560cc1c
prev parent reply other threads:[~2024-11-20 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 6:08 [PATCH] netfs: silence an uninitialized variable warning Dan Carpenter
2024-11-20 8:28 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241120-lageplan-kneifen-e124b37dee93@brauner \
--to=brauner@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox