netfs.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neil@brown.name>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	David Howells <dhowells@redhat.com>,
	Chuck Lever <chuck.lever@oracle.com>,
	Jeff Layton <jlayton@kernel.org>
Cc: linux-nfs@vger.kernel.org, netfs@lists.linux.dev,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH 0/6 RFC v2] tidy up various VFS lookup functions
Date: Wed, 19 Mar 2025 14:01:31 +1100	[thread overview]
Message-ID: <20250319031545.2999807-1-neil@brown.name> (raw)

This a revised version of a previous posting.  I have dropped the change
to some lookup functions to pass a vfsmount.  I have also dropped the
changes to nfsd and cachefiles which passed a mnt_idmap other than
&nop_mnt_idmap.  Those modules now explicitly pass &nop_mnt_idmap to
some lookup functions where previously that was implicit.

============== Revised cover letter.

VFS has some functions with names containing "lookup_one_len" and others
without the "_len".  This difference has nothing to do with "len".  This
is an historical accident but can be confusing.

The functions without "_len" take a "mnt_idmap" pointer.  This is found
in the "vfsmount" and that is an important question when choosing which
to use: do you have a vfsmount, or are you "inside" the filesystem.  A
related question is "is permission checking relevant here?".

nfsd and cachefiles *do* have a vfsmount but *don't* use the non-_len
functions.  They pass nop_mnt_idmap and refuse to work on filesystems
which have any other idmap.

This series changes nfsd and cachefile to use the lookup_one family of
functions and to explictily pass &nop_mnt_idmap which is consistent with
all other vfs interfaces used where &nop_mnt_idmap is explicitly passed.

The remaining uses of the "_one" functions do not require permission
checks so these are renamed to be "_noperm" and the permission checking
is removed.

This series also changes these lookup function to take a qstr instead of
separate name and len.  In many cases this simplifies the call.

I haven't included changes to afs because there are patches in vfs.all
which make a lot of changes to lookup in afs.  I think (if they are seen
as a good idea) these patches should aim to land after the afs patches
and any further fixup in afs can happen then.

These patches are based on vfs-6.15.async.dir as they touch mkdir
related code.  There is a small conflict with the recently posted patch
to remove locking from try_lookup_one_len() calls.

Thanks,
NeilBrown

 [PATCH 1/6] VFS: improve interface for lookup_one functions
 [PATCH 2/6] nfsd: Use lookup_one() rather than lookup_one_len()
 [PATCH 3/6] cachefiles: Use lookup_one() rather than lookup_one_len()
 [PATCH 4/6] VFS: rename lookup_one_len family to lookup_noperm and
 [PATCH 5/6] Use try_lookup_noperm() instead of d_hash_and_lookup()
 [PATCH 6/6] VFS: change lookup_one_common and lookup_noperm_common to

             reply	other threads:[~2025-03-19  3:16 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-19  3:01 NeilBrown [this message]
2025-03-19  3:01 ` [PATCH 1/6] VFS: improve interface for lookup_one functions NeilBrown
2025-03-19  8:40   ` Christian Brauner
2025-03-20 10:17   ` Jeff Layton
2025-03-22  0:27   ` Al Viro
2025-03-28  1:14     ` NeilBrown
2025-03-19  3:01 ` [PATCH 2/6] nfsd: Use lookup_one() rather than lookup_one_len() NeilBrown
2025-03-19 13:04   ` Chuck Lever
2025-03-20 10:19   ` Jeff Layton
2025-03-19  3:01 ` [PATCH 3/6] cachefiles: " NeilBrown
2025-03-20 10:22   ` Jeff Layton
2025-03-20 12:05     ` Christian Brauner
2025-03-20 13:49     ` David Howells
2025-03-20 14:04       ` Christian Brauner
2025-03-19  3:01 ` [PATCH 4/6] VFS: rename lookup_one_len family to lookup_noperm and remove permission check NeilBrown
2025-03-20 10:29   ` Jeff Layton
2025-03-22  0:34   ` Al Viro
2025-03-28  1:31     ` NeilBrown
2025-03-19  3:01 ` [PATCH 5/6] Use try_lookup_noperm() instead of d_hash_and_lookup() outside of VFS NeilBrown
2025-03-20 10:45   ` Jeff Layton
2025-03-22  0:39   ` Al Viro
2025-03-19  3:01 ` [PATCH 6/6] VFS: change lookup_one_common and lookup_noperm_common to take a qstr NeilBrown
2025-03-20 10:46   ` Jeff Layton
2025-03-19  8:42 ` [PATCH 0/6 RFC v2] tidy up various VFS lookup functions Christian Brauner
2025-03-19  9:23   ` NeilBrown
2025-03-20 14:04 ` [PATCH 1/6] VFS: improve interface for lookup_one functions David Howells
2025-03-22  0:29   ` Al Viro
2025-03-28  1:18   ` NeilBrown
2025-04-04 13:41     ` Christian Brauner
2025-04-04 13:46       ` Christian Brauner
2025-04-04 23:00         ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250319031545.2999807-1-neil@brown.name \
    --to=neil@brown.name \
    --cc=brauner@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=dhowells@redhat.com \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=netfs@lists.linux.dev \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).