Re: [PATCH v4 07/11] cifs: Clean up some places where an extra kvec[] was required for rfc1002

Stefan Metzmacher
2025-11-24T14:41:01Z

Am 24.11.25 um 15:36 schrieb David Howells:
> Hi Stefan,
>
> Stefan Metzmacher <metze@samba.org> wrote:
>
>> I had to squash this into the patch
>>
>> I'm using smatch when building and got the following error
>> with this change:
>>
>> client/transport.c:1073 compound_send_recv() error: we previously assumed 'resp_iov' could be null (see line 1051)
>> ...
>> if ((ses->ses_status == SES_NEW) || (optype & CIFS_NEG_OP) || (optype & CIFS_SESS_OP)) {
>
> In this case smatch is wrong, though it can't work this out as the context
> spans more than one file. This clause applies only to certain operations
> (such as session setup and negotiate) that will always have a response buffer.
> But I've no objection to adding this warning to splat the warning.

Ok, I can just squash as well as the EIO changes below my branch
I'll hopefully be able to post later today or tomorrow.

My idea would be that my branch would replace ksmbd-for-next
and add your any my changes on top.

Thanks!
metze