From: nspmangalore@gmail.com
To: linux-cifs@vger.kernel.org, smfrench@gmail.com, pc@manguebit.org,
bharathsm@microsoft.com, dhowells@redhat.com,
netfs@lists.linux.dev
Cc: Shyam Prasad N <sprasad@microsoft.com>
Subject: [PATCH v3 3/4] netfs: avoid double increment of retry_count in subreq
Date: Thu, 29 Jan 2026 23:07:10 +0530 [thread overview]
Message-ID: <20260129173725.887651-3-sprasad@microsoft.com> (raw)
In-Reply-To: <20260129173725.887651-1-sprasad@microsoft.com>
From: Shyam Prasad N <sprasad@microsoft.com>
This change fixes the instance of double incrementing of
retry_count. The increment of this count already happens
when netfs_reissue_write gets called. Incrementing this
value before is not necessary.
Fixes: 4acb665cf4f3 ("netfs: Work around recursion by abandoning retry if nothing read")
Cc: David Howells <dhowells@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
---
fs/netfs/write_retry.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/netfs/write_retry.c b/fs/netfs/write_retry.c
index fc9c3e0d34d81..29489a23a2209 100644
--- a/fs/netfs/write_retry.c
+++ b/fs/netfs/write_retry.c
@@ -98,7 +98,6 @@ static void netfs_retry_write_stream(struct netfs_io_request *wreq,
subreq->start = start;
subreq->len = len;
__clear_bit(NETFS_SREQ_NEED_RETRY, &subreq->flags);
- subreq->retry_count++;
trace_netfs_sreq(subreq, netfs_sreq_trace_retry);
/* Renegotiate max_len (wsize) */
--
2.43.0
next prev parent reply other threads:[~2026-01-29 17:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 17:37 [PATCH v3 1/4] cifs: on replayable errors back-off before replay, not after nspmangalore
2026-01-29 17:37 ` [PATCH v3 2/4] netfs: when subreq is marked for retry, do not check if it faced an error nspmangalore
2026-01-30 13:24 ` David Howells
2026-01-29 17:37 ` nspmangalore [this message]
2026-01-30 13:25 ` [PATCH v3 3/4] netfs: avoid double increment of retry_count in subreq David Howells
2026-01-29 17:37 ` [PATCH v3 4/4] cifs: make retry logic in read/write path consistent with other paths nspmangalore
2026-01-30 13:36 ` David Howells
2026-01-31 8:17 ` Shyam Prasad N
2026-01-30 3:37 ` [PATCH v3 1/4] cifs: on replayable errors back-off before replay, not after Steve French
2026-01-31 8:35 ` Shyam Prasad N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260129173725.887651-3-sprasad@microsoft.com \
--to=nspmangalore@gmail.com \
--cc=bharathsm@microsoft.com \
--cc=dhowells@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox