From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C9EB39A805 for ; Sat, 25 Apr 2026 12:55:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777121744; cv=none; b=ZDspld1dfB9kXx5ZdLQ0oDqVPX0Kez5yPEfdlm65JHXWiDME4qw992ddJy7dBPiRVKXllALSsKhwcJ4ByOWSZI4incxwNr67za09mZ5tCwT9PzBfnVtBkNfBz5FaGshxpJ2Gr3QzJvOI0emlnQDZWGnei7JSwihDx3lGy0qb2lM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777121744; c=relaxed/simple; bh=pqehrGUvFhKSXNHxOH4q0/fAGSySis+WX/zGELva8lg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:content-type; b=btO6FdQ1RoxYTW98PaInnqmoqoiHoA/6B+WLd6Kwrp8Y5c25tCNAwc2hKuU2wFrpcI9q6qngZH9GlYR4CjYaiBeMu7FG358uQMCe4CcvkJIk6bVclKjvEDU9funLDRptD6Wivv0JIBH96jDFAyLeVDARhgt2mEoSGDvUz5u+mMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VgiXVIS7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VgiXVIS7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777121742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fwIrRp2mzgM5XL791ck6rIOO1IU+DN7HcZOIJ0dzRVg=; b=VgiXVIS7qmZ2UJh7GkKbS9ASTriH3Qc6Xji/AE7RMsFTzboLdXJILwXBt8J2jXxOsHmxV2 rOXqssTQhu4cXVbSZ3II2UOC5p+w3XorbuAP4Ot/aHOryYOD0jDRLy+4gCycdpAaNiOIx1 upUIo0cj7k5LqCWbB0hKKKgpERePPDk= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-444-rpa-kcBiONqFcRllCfwgDQ-1; Sat, 25 Apr 2026 08:55:39 -0400 X-MC-Unique: rpa-kcBiONqFcRllCfwgDQ-1 X-Mimecast-MFC-AGG-ID: rpa-kcBiONqFcRllCfwgDQ_1777121737 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9A6EE1800464; Sat, 25 Apr 2026 12:55:37 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.44.48.17]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 949791944CED; Sat, 25 Apr 2026 12:55:34 +0000 (UTC) From: David Howells To: Christian Brauner Cc: David Howells , Paulo Alcantara , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Wilcox Subject: [PATCH v3 13/19] netfs: Fix partial invalidation of streaming-write folio Date: Sat, 25 Apr 2026 13:54:17 +0100 Message-ID: <20260425125426.3855807-14-dhowells@redhat.com> In-Reply-To: <20260425125426.3855807-1-dhowells@redhat.com> References: <20260425125426.3855807-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: netfs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-MFC-PROC-ID: mODApD0Rlf4sLLrqHQ81K9UEsES8q7tYc9EfDgxFdUs_1777121737 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true In netfs_invalidate_folio(), if the region of a partial invalidation overlaps the front (but not all) of a dirty write cached in a streaming write page (dirty, but not uptodate, with the dirty region tracked by a netfs_folio struct), the function modifies the dirty region - but incorrectly as it moves the region forward by setting the start to the start, not the end, of the invalidation region. Fix this by setting finfo->dirty_offset to the end of the invalidation region (iend). Fixes: cce6bfa6ca0e ("netfs: Fix trimming of streaming-write folios in netfs_inval_folio()") Closes: https://sashiko.dev/#/patchset/20260414082004.3756080-1-dhowells%40redhat.com Signed-off-by: David Howells cc: Paulo Alcantara cc: Matthew Wilcox cc: netfs@lists.linux.dev cc: linux-fsdevel@vger.kernel.org --- fs/netfs/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/netfs/misc.c b/fs/netfs/misc.c index e386cf31eb1e..8b457124b0e3 100644 --- a/fs/netfs/misc.c +++ b/fs/netfs/misc.c @@ -255,7 +255,7 @@ void netfs_invalidate_folio(struct folio *folio, size_t offset, size_t length) goto erase_completely; /* Move the start of the data. */ finfo->dirty_len = fend - iend; - finfo->dirty_offset = offset; + finfo->dirty_offset = iend; trace_netfs_folio(folio, netfs_folio_trace_invalidate_front); return; }