From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@infradead.org>
Cc: David Howells <dhowells@redhat.com>,
Paulo Alcantara <pc@manguebit.org>, Jens Axboe <axboe@kernel.dk>,
Leon Romanovsky <leon@kernel.org>,
Steve French <sfrench@samba.org>,
ChenXiaoSong <chenxiaosong@chenxiaosong.com>,
Marc Dionne <marc.dionne@auristor.com>,
Eric Van Hensbergen <ericvh@kernel.org>,
Dominique Martinet <asmadeus@codewreck.org>,
Ilya Dryomov <idryomov@gmail.com>,
Trond Myklebust <trondmy@kernel.org>,
netfs@lists.linux.dev, linux-afs@lists.infradead.org,
linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
ceph-devel@vger.kernel.org, v9fs@lists.linux.dev,
linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>
Subject: [PATCH v2 12/21] cifs: Support ITER_BVECQ in smb_extract_iter_to_rdma()
Date: Mon, 18 May 2026 23:29:44 +0100 [thread overview]
Message-ID: <20260518222959.488126-13-dhowells@redhat.com> (raw)
In-Reply-To: <20260518222959.488126-1-dhowells@redhat.com>
Add support for ITER_BVECQ to smb_extract_iter_to_rdma().
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Paulo Alcantara <pc@manguebit.org>
cc: Matthew Wilcox <willy@infradead.org>
cc: Christoph Hellwig <hch@infradead.org>
cc: Steve French <sfrench@samba.org>
cc: Shyam Prasad N <sprasad@microsoft.com>
cc: Tom Talpey <tom@talpey.com>
cc: linux-cifs@vger.kernel.org
cc: netfs@lists.linux.dev
cc: linux-fsdevel@vger.kernel.org
---
fs/smb/smbdirect/connection.c | 66 +++++++++++++++++++++++++++++++++++
1 file changed, 66 insertions(+)
diff --git a/fs/smb/smbdirect/connection.c b/fs/smb/smbdirect/connection.c
index 8adf58097534..4d2a1700104e 100644
--- a/fs/smb/smbdirect/connection.c
+++ b/fs/smb/smbdirect/connection.c
@@ -5,6 +5,7 @@
*/
#include "internal.h"
+#include <linux/bvecq.h>
#include <linux/folio_queue.h>
struct smbdirect_map_sges {
@@ -2006,6 +2007,68 @@ static ssize_t smbdirect_map_sges_from_bvec(struct iov_iter *iter,
return ret;
}
+/*
+ * Extract memory fragments from a BVECQ-class iterator and add them to an RDMA
+ * list. The fragments are not pinned.
+ */
+static ssize_t smbdirect_map_sges_from_bvecq(struct iov_iter *iter,
+ struct smbdirect_map_sges *state,
+ ssize_t maxsize)
+{
+ const struct bvecq *bq = iter->bvecq;
+ unsigned int slot = iter->bvecq_slot;
+ ssize_t extracted = 0;
+ size_t offset = iter->iov_offset;
+
+ maxsize = umin(maxsize, iov_iter_count(iter));
+
+ do {
+ struct bio_vec *bv;
+ size_t bsize;
+
+ while (slot >= bq->nr_slots) {
+ if (!bq->next) {
+ if (WARN_ON_ONCE(maxsize > 0))
+ return -EIO;
+ goto out;
+ }
+ bq = bq->next;
+ slot = 0;
+ }
+
+ bv = &bq->bv[slot];
+ bsize = bv->bv_len;
+
+ if (offset < bsize) {
+ size_t part = umin(maxsize, bsize - offset);
+ bool ok;
+
+ ok = smbdirect_map_sges_single_page(state,
+ bv->bv_page,
+ bv->bv_offset + offset,
+ part);
+ if (!ok)
+ return -EIO;
+
+ offset += part;
+ extracted += part;
+ maxsize -= part;
+ }
+
+ if (offset >= bsize) {
+ offset = 0;
+ slot++;
+ }
+ } while (state->num_sge < state->max_sge && maxsize > 0);
+
+out:
+ iter->bvecq = bq;
+ iter->bvecq_slot = slot;
+ iter->iov_offset = offset;
+ iter->count -= extracted;
+ return extracted;
+}
+
/*
* Extract fragments from a KVEC-class iterator and add them to an ib_sge list.
* This can deal with vmalloc'd buffers as well as kmalloc'd or static buffers.
@@ -2155,6 +2218,9 @@ static ssize_t smbdirect_map_sges_from_iter(struct iov_iter *iter, size_t len,
case ITER_BVEC:
ret = smbdirect_map_sges_from_bvec(iter, state, len);
break;
+ case ITER_BVECQ:
+ ret = smbdirect_map_sges_from_bvecq(iter, state, len);
+ break;
case ITER_KVEC:
ret = smbdirect_map_sges_from_kvec(iter, state, len);
break;
next prev parent reply other threads:[~2026-05-18 22:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 22:29 [PATCH v2 00/21] netfs: Keep track of folios in a segmented bio_vec[] chain David Howells
2026-05-18 22:29 ` [PATCH v2 01/21] cachefiles: Don't rely on backing fs storage map for most use cases David Howells
2026-05-18 22:29 ` [PATCH v2 02/21] netfs: Add the cache object ID to netfs_read/write tracepoints David Howells
2026-05-18 22:29 ` [PATCH v2 03/21] mm: Make readahead store folio count in readahead_control David Howells
2026-05-18 22:29 ` [PATCH v2 04/21] netfs: Bulk load the readahead-provided folios up front David Howells
2026-05-18 22:29 ` [PATCH v2 05/21] Add a function to kmap one page of a multipage bio_vec David Howells
2026-05-25 6:13 ` Christoph Hellwig
2026-06-04 14:25 ` David Howells
2026-05-18 22:29 ` [PATCH v2 06/21] iov_iter: Make iov_iter_get_pages*() wrap iov_iter_extract_pages() David Howells
2026-05-25 6:13 ` Christoph Hellwig
2026-06-04 14:26 ` David Howells
2026-05-18 22:29 ` [PATCH v2 07/21] iov_iter: Add a segmented queue of bio_vec[] David Howells
2026-05-18 22:29 ` [PATCH v2 08/21] netfs: Add some tools for managing bvecq chains David Howells
2026-05-18 22:29 ` [PATCH v2 09/21] netfs: Add a function to extract from an iter into a bvecq David Howells
2026-05-18 22:29 ` [PATCH v2 10/21] afs: Use a bvecq to hold dir content rather than folioq David Howells
2026-05-18 22:29 ` [PATCH v2 11/21] cifs: Use a bvecq for buffering instead of a folioq David Howells
2026-05-18 22:29 ` David Howells [this message]
2026-05-19 8:18 ` [PATCH v2 12/21] cifs: Support ITER_BVECQ in smb_extract_iter_to_rdma() Stefan Metzmacher
2026-05-18 22:29 ` [PATCH v2 13/21] netfs: Switch to using bvecq rather than folio_queue and rolling_buffer David Howells
2026-05-18 22:29 ` [PATCH v2 14/21] cifs: Remove support for ITER_FOLIOQ from smb_extract_iter_to_rdma() David Howells
2026-05-19 8:19 ` Stefan Metzmacher
2026-05-18 22:29 ` [PATCH v2 15/21] netfs: Remove netfs_alloc/free_folioq_buffer() David Howells
2026-05-18 22:29 ` [PATCH v2 16/21] netfs: Remove netfs_extract_user_iter() David Howells
2026-05-18 22:29 ` [PATCH v2 17/21] iov_iter: Remove ITER_FOLIOQ David Howells
2026-05-18 22:29 ` [PATCH v2 18/21] netfs: Remove folio_queue and rolling_buffer David Howells
2026-05-18 22:29 ` [PATCH v2 19/21] netfs: Check for too much data being read David Howells
2026-05-18 22:29 ` [PATCH v2 20/21] netfs: Limit the minimum trigger for progress reporting David Howells
2026-05-18 22:29 ` [PATCH v2 21/21] netfs: Combine prepare and issue ops and grab the buffers on request David Howells
2026-05-19 8:15 ` [PATCH v2 00/21] netfs: Keep track of folios in a segmented bio_vec[] chain David Laight
2026-05-19 8:56 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518222959.488126-13-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=asmadeus@codewreck.org \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=chenxiaosong@chenxiaosong.com \
--cc=christian@brauner.io \
--cc=ericvh@kernel.org \
--cc=hch@infradead.org \
--cc=idryomov@gmail.com \
--cc=leon@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=v9fs@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox