From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC9C136CDF3 for ; Fri, 19 Jun 2026 14:07:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781878034; cv=none; b=q0kglnCki+qHMgNhszBqnnWacjvjkQzS3QovAF4ftDfDC4F3NGCpXWTe/aS+zn0R0SADrxeMMQOxlqB4NESo2MQhwPXZCkHlYT3/rVn7XzPMeCxr6kvoaKKUoodoLoB2Jf5ZMOdfL5fG9nNzBoY+YxgZI+ecc7rC4h7ZukYQpD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781878034; c=relaxed/simple; bh=RdvGg5oUDGJEEdfGJGQ/pnwBlwSc3oIQFuXQ0iNSvAc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:content-type; b=T+qzegPcxMQdenhEqXiUu1hyEOEm+V7ZhUrSZm9qyL4o0HBODI/342gadoP8fPfaD7tQo0yPFem+hRkpLPWRp57MS6ksxB3QhJCyzcAk7EWkZTqQ5taTXBgHH2rXPw0VcNAy5oj4bvlFYS5qaEWI9VoywJk/Seo8axr/x+BE26w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=D2NtUGWx; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="D2NtUGWx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781878031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UCH9AytniZX5CSjSRd/+qJL1T4JneHVxw5zGHZC2I1o=; b=D2NtUGWxk1NP0cLo4VYDrhnrlucUV9slTW7EuwzBIMRzYyLbRKAN9CuF1b6Rw0zvk/oPQe VELy8A1Z8rbROutb68G57B9sDhFleIqAnrMTJzAdkNPYBOYfIqKngsTW9K1jChAao8HHix rbHI69fjno03GPGTTfghsnBuNC8kPrA= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-rbFu6V7FMce8_slh70AaNw-1; Fri, 19 Jun 2026 10:07:09 -0400 X-MC-Unique: rbFu6V7FMce8_slh70AaNw-1 X-Mimecast-MFC-AGG-ID: rbFu6V7FMce8_slh70AaNw_1781878028 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 81D9B1801F36; Fri, 19 Jun 2026 14:07:07 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.44.50.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A151518005A4; Fri, 19 Jun 2026 14:07:04 +0000 (UTC) From: David Howells To: Christian Brauner Cc: David Howells , Paulo Alcantara , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, NeilBrown Subject: [PATCH 03/11] cachefiles: Fix file burial to take lock when unsetting S_KERNEL_FILE Date: Fri, 19 Jun 2026 15:06:07 +0100 Message-ID: <20260619140646.2633762-4-dhowells@redhat.com> In-Reply-To: <20260619140646.2633762-1-dhowells@redhat.com> References: <20260619140646.2633762-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: netfs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-MFC-PROC-ID: Jz39bXyxwXYdnLsf_iYzE13271tQv_T6ZJHjHE4MMKE_1781878028 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Fix cachefiles_bury_object() to lock the inode of the file being buried whilst it unsets the S_KERNEL_FILE flag. Fixes: 07a90e97400c ("cachefiles: Implement culling daemon commands") Closes: https://sashiko.dev/#/patchset/20260616100821.2062304-1-dhowells%40redhat.com Signed-off-by: David Howells cc: Paulo Alcantara cc: NeilBrown cc: netfs@lists.linux.dev cc: linux-fsdevel@vger.kernel.org --- fs/cachefiles/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cachefiles/namei.c b/fs/cachefiles/namei.c index a464c4646c04..d4309dfb55df 100644 --- a/fs/cachefiles/namei.c +++ b/fs/cachefiles/namei.c @@ -375,7 +375,7 @@ int cachefiles_bury_object(struct cachefiles_cache *cache, "Rename failed with error %d", ret); } - __cachefiles_unmark_inode_in_use(object, d_inode(rep)); + cachefiles_do_unmark_inode_in_use(object, d_inode(rep)); end_renaming(&rd); _leave(" = 0"); return 0;