Linux network filesystem support library
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Iván Ezequiel Rodriguez" <ivanrwcm25@gmail.com>,
	"David Howells" <dhowells@redhat.com>,
	"Paulo Alcantara" <pc@manguebit.org>,
	netfs@lists.linux.dev
Cc: oe-kbuild-all@lists.linux.dev,
	Shyam Prasad N <sprasad@microsoft.com>,
	Steve French <stfrench@microsoft.com>,
	linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH netfs v1 2/2] netfs: add KUnit coverage for reissue prepare_write errno
Date: Thu, 29 Oct 2026 18:19:34 +0800	[thread overview]
Message-ID: <202610291753.Jr3HECY2-lkp@intel.com> (raw)
In-Reply-To: <20261028181229.1408342-3-ivanrwcm25@gmail.com>

Hi Iván,

kernel test robot noticed the following build warnings:

[auto build test WARNING on brauner-vfs/vfs.all]
[also build test WARNING on linus/master v7.3 next-20261028]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Iv-n-Ezequiel-Rodriguez/netfs-preserve-prepare_write-errno-on-reissue/20261028-151228
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20261028181229.1408342-3-ivanrwcm25%40gmail.com
patch subject: [PATCH netfs v1 2/2] netfs: add KUnit coverage for reissue prepare_write errno
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20261029/202610291753.Jr3HECY2-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 16.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261029/202610291753.Jr3HECY2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610291753.Jr3HECY2-lkp@intel.com/

All warnings (new ones prefixed by >>):

   fs/netfs/write_reissue_kunit.c: In function 'reissue_preserves_prep_error':
>> fs/netfs/write_reissue_kunit.c:61:1: warning: the frame size of 1400 bytes is larger than 1280 bytes [-Wframe-larger-than=]
      61 | }
         | ^


vim +61 fs/netfs/write_reissue_kunit.c

    25	
    26	/*
    27	 * prepare_write_failed() sets FAILED + errno, then write_retry still calls
    28	 * reissue_write().  Before the fix, reissue wiped error to 0 so terminated
    29	 * reported success and mapping_set_error(0) was a no-op.
    30	 */
    31	static void reissue_preserves_prep_error(struct kunit *test)
    32	{
    33		struct term_capture cap = {};
    34		struct netfs_io_request wreq = {};
    35		struct netfs_io_stream stream = {
    36			.source = NETFS_UPLOAD_TO_SERVER,
    37		};
    38		struct netfs_io_subrequest subreq = {
    39			.rreq = &wreq,
    40			.len = 1,
    41			.transferred = 0,
    42			.error = -EIO,
    43			.source = NETFS_UPLOAD_TO_SERVER,
    44		};
    45		char buf[1] = { 0 };
    46		struct kvec kvec = { .iov_base = buf, .iov_len = 1 };
    47		struct iov_iter source;
    48	
    49		__set_bit(NETFS_SREQ_FAILED, &subreq.flags);
    50		iov_iter_kvec(&source, ITER_SOURCE, &kvec, 1, 1);
    51	
    52		test->priv = &cap;
    53		kunit_activate_static_stub(test, netfs_write_subrequest_terminated,
    54					   capture_terminated);
    55	
    56		netfs_reissue_write(&stream, &subreq, &source);
    57	
    58		KUNIT_EXPECT_TRUE(test, cap.called);
    59		KUNIT_EXPECT_EQ(test, cap.transferred_or_error, -EIO);
    60		KUNIT_EXPECT_EQ(test, subreq.error, -EIO);
  > 61	}
    62	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

      reply	other threads:[~2026-10-29 10:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 18:12 [PATCH netfs v1 0/2] preserve prepare_write errno across write reissue Iván Ezequiel Rodriguez
2026-10-28 18:12 ` [PATCH netfs v1 1/2] netfs: preserve prepare_write errno on reissue Iván Ezequiel Rodriguez
2026-10-28 18:12 ` [PATCH netfs v1 2/2] netfs: add KUnit coverage for reissue prepare_write errno Iván Ezequiel Rodriguez
2026-10-29 10:19   ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202610291753.Jr3HECY2-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=dhowells@redhat.com \
    --cc=ivanrwcm25@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfs@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pc@manguebit.org \
    --cc=sprasad@microsoft.com \
    --cc=stfrench@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox