From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7653113E020 for ; Wed, 24 Jul 2024 08:11:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721808690; cv=none; b=sPIUCsCmdjrABnN1h3gWEr9zSEfOtAGHX2rr1EaN5hpojRt5dJyrk45pVRlXmzPTUSas8/4yG7/d98eaEGkgVsVOE81iU1hCoyS4pWP2R3xg89dqSY4RBVhWVTM1qCWVLrJaPh36d8OyMBbwzs7KgXzgvzTlwJOOWccAIwshQck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721808690; c=relaxed/simple; bh=s7hhqchaxiQuHgy5U50MusziEH9As6ZvAjpUDnWXGJo=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=HYDW48Zx4Uy1ULlr7ril1Ub6hMMsXCbMRUIasKVomhaJDmEjJewkrypYwTU4FRneQe2uMflgbH+MkMwyU81L6J4wlEOX5GdXHb56UxWXX2X+xWpfHa3Af6jEr/ZDuhd84OSaufZoZVPIHQY5Fd/1kqBiEVOjuamCg0YkHA3gFSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JB80oGYx; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JB80oGYx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721808688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jyvRNlCo7H0nMKeExwfupCt0YeZsChO27NKXONbPwMM=; b=JB80oGYxMFgk8Sg1inBg9gedRHqqp0J/tkvJQl4QvYK2TwLjjNT6a7iHY1T714QmBdo4QL o12v86FmVCX9z1synovyVoqR89kSMbjYFdS0W73tPRQXmYxOYF49J6o3A2SuMofhnuFH9a 1H3erjeXoC1scMp0l3yfp3O2+ty95Uw= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-93UXihc1OoisumPKDlRIJw-1; Wed, 24 Jul 2024 04:11:23 -0400 X-MC-Unique: 93UXihc1OoisumPKDlRIJw-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0A00C19560A1; Wed, 24 Jul 2024 08:11:21 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.216]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 92B4B3000197; Wed, 24 Jul 2024 08:11:17 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240723125710.mtnfaycuvdi4dpdy@quack3> References: <20240723125710.mtnfaycuvdi4dpdy@quack3> <2136178.1721725194@warthog.procyon.org.uk> To: Jan Kara Cc: dhowells@redhat.com, Alexander Viro , Christian Brauner , Jeff Layton , Gao Xiang , Matthew Wilcox , netfs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vfs: Fix potential circular locking through setxattr() and removexattr() Precedence: bulk X-Mailing-List: netfs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2237317.1721808676.1@warthog.procyon.org.uk> Date: Wed, 24 Jul 2024 09:11:16 +0100 Message-ID: <2237318.1721808676@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Jan Kara wrote: > > + error = strncpy_from_user(kname, name, sizeof(kname)); > > + if (error == 0 || error == sizeof(kname)) > > + error = -ERANGE; > > + if (error < 0) > > + return error; > > Missing fdput() here. Thanks. I think Christian is altering the patch to use auto-destruction constructs (CLASS()). David