From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F2892E03F5 for ; Fri, 30 Jan 2026 13:24:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769779494; cv=none; b=Q9Cv++P77KO3s4OfAD13uWp5oSWaw/H2hT2AuSphC569rqLRalKXw07xLer86eozPtse4WJ160cLMvtP8ANQq5TB0JL+Fkn3+wcWAzFTO97jIfSNSurAg8jPQ1pkRIbEFVVd1AN1WTb7TIIePffAlCYecAKmz3mNHoHxB3yFSZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769779494; c=relaxed/simple; bh=b/hcOjFRWOOYet6L1gL6zk0O+RAvqV44hNeisWhTocU=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=ayZgfsjyM5JJUmEjb2aXrSAuWtMvCXaqEzgUe4jjokJ+aMaufQTVgwYF7x/UiaRpRPKYT0pvcr3tApQzFoxBbxPiX7HDXrjuJ8Nwol6f83B1WUxXxtTrVJ6hhs4CvwmWfrnf49WfKIkLE9FC8TMO6ji7Et2RR374rbaEHc+GMZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IUAeY4Vs; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IUAeY4Vs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769779492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BXM0JO7oUPN2l7gs39D3NSlPcrZU7IvbD8zukACQptk=; b=IUAeY4Vs3Y2i02wYyF3ESPIxewk+/MV8yFQ4xmmjOqH1iwF8UjbckaHQ8WZ4NNha/nl7BB M3p6QoxcHPsMA9aqPFCVudSBSuOZinySkNUHDPZ0SFGnhB4KYN3DaQGTBoYEVuMRHkhNmr qy8tYU7nqEViLofEP6PrgpvBoPEcJdg= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-R_-96B1EMiCgHMX0xqI8Dw-1; Fri, 30 Jan 2026 08:24:46 -0500 X-MC-Unique: R_-96B1EMiCgHMX0xqI8Dw-1 X-Mimecast-MFC-AGG-ID: R_-96B1EMiCgHMX0xqI8Dw_1769779485 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 91F3E18005A7; Fri, 30 Jan 2026 13:24:45 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.44.33.164]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3D6081956056; Fri, 30 Jan 2026 13:24:43 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20260129173725.887651-2-sprasad@microsoft.com> References: <20260129173725.887651-2-sprasad@microsoft.com> <20260129173725.887651-1-sprasad@microsoft.com> To: nspmangalore@gmail.com Cc: dhowells@redhat.com, linux-cifs@vger.kernel.org, smfrench@gmail.com, pc@manguebit.org, bharathsm@microsoft.com, netfs@lists.linux.dev, Shyam Prasad N Subject: Re: [PATCH v3 2/4] netfs: when subreq is marked for retry, do not check if it faced an error Precedence: bulk X-Mailing-List: netfs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2263608.1769779481.1@warthog.procyon.org.uk> Date: Fri, 30 Jan 2026 13:24:41 +0000 Message-ID: <2263609.1769779481@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 nspmangalore@gmail.com wrote: > + /* if need retry is set, error should not matter. pause the rreq */ I think I'd say: /* If need retry is set, error should not matter unless we hit too * many retries. Pause the generation of new subreqs. */ But other than that: Acked-by: David Howells