Re: [PATCH v3 4/4] cifs: make retry logic in read/write path consistent with other paths

David Howells
2026-01-30T13:37:01Z

nspmangalore@gmail.com wrote:

> + unsigned int retries; /* number of retries so far */

Is this redundant with netfs_io_subrequest::retry_count? (This can be changed
from u8 to unsigned int if it helps). I suspect that there might be a fight
over who gets to increment it, though.

> + if (is_replayable_error(rc)) {
> + trace_netfs_sreq(&rdata->subreq, netfs_sreq_trace_io_req_submitted);
> + __set_bit(NETFS_SREQ_NEED_RETRY, &rdata->subreq.flags);

You didn't see MID_RESPONSE_SUBMITTED, so I would pick a different trace value
there.

David