Re: [PATCH v3 4/4] cifs: make retry logic in read/write path consistent with other paths

Shyam Prasad N
2026-01-31T08:18:08Z

On Fri, Jan 30, 2026 at 7:06 PM David Howells <dhowells@redhat.com> wrote:
>
> nspmangalore@gmail.com wrote:
>
> > + unsigned int retries; /* number of retries so far */
>
> Is this redundant with netfs_io_subrequest::retry_count? (This can be changed
> from u8 to unsigned int if it helps). I suspect that there might be a fight
> over who gets to increment it, though.

This is mainly used to track the number of retransmissions from the
client (retrans mount option) when soft mounts are used.
I don't mind netfs doing it's own tracking (the purpose maybe
different from what is there here). I don't see a major issue if
they're not in sync with each other too.
So I'm okay with that.

>
> > + if (is_replayable_error(rc)) {
> > + trace_netfs_sreq(&rdata->subreq, netfs_sreq_trace_io_req_submitted);
> > + __set_bit(NETFS_SREQ_NEED_RETRY, &rdata->subreq.flags);
>
> You didn't see MID_RESPONSE_SUBMITTED, so I would pick a different trace value
> there.

That's a typo. Thanks for reviewing. Will fix it.

>
> David
>

--
Regards,
Shyam