From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEA121BFE0F for ; Thu, 10 Oct 2024 11:23:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728559396; cv=none; b=t+NNOrr/UgMyCJ5DpQK8sB9+CiMTjQzbhA3tIe7p8if7xf+xokCWU11HqQC/rJqm7QZrhXMGcq5nUMjyW1eiT5wAbdkLUSXsYzuMeeQTOW3kUkhvoNDANs4bXX0dW4XBYi9GYWNlz4DvcXLOrX0SbpuqOGrqEAOdvkBrDOQb7EE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728559396; c=relaxed/simple; bh=x9iaGYlku1I61w3bKz/b2Pv+BfrZU92jU/nEmEgj4Fo=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=ASozcgM3GyWrI4wI6T8Up+PUlX7QLPuJf3hhc0lzsH3bS0c7g+J4qffxRJ+nM0jExQ9tcaj/iBIuBrvg5ltKPUXXHvpfdFRft6FRLn2GC1Mfe5FZ8bUlZ2DhJHFhPSc1aeweDdkMvZDW+g/Djodp5eujwD0dh/riGGtjIZKwhEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eSprLnaC; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eSprLnaC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728559393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0NXJ/YlAi2284RdYmfvHVqovUyQSlsXPT+gI0a/FAik=; b=eSprLnaCsf1tcJuVsTpJ6P35So5Ovex0QzBnH/478WmQyh4FycBa3z7v0CNin2nTqNvROS Nnbyp9kr9symGpxrQAbzktgHkhiz4zRmgc5YJ1dEOYwL+3m2acUGcVFugPK/VmwFaf0Gmu j0Q0Vp2DQ5hqClmySkrFqbPfUcI4TAI= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-371-i8qS1cvJP6ysisq-7AS9jg-1; Thu, 10 Oct 2024 07:23:10 -0400 X-MC-Unique: i8qS1cvJP6ysisq-7AS9jg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D9F8C1956096; Thu, 10 Oct 2024 11:23:07 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 984581956086; Thu, 10 Oct 2024 11:23:03 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240821024301.1058918-6-wozizhi@huawei.com> References: <20240821024301.1058918-6-wozizhi@huawei.com> <20240821024301.1058918-1-wozizhi@huawei.com> To: Zizhi Wo Cc: dhowells@redhat.com, netfs@lists.linux.dev, jlayton@kernel.org, hsiangkao@linux.alibaba.com, jefflexu@linux.alibaba.com, zhujia.zj@bytedance.com, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, libaokun1@huawei.com, yangerkun@huawei.com, houtao1@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH 5/8] cachefiles: Clean up in cachefiles_commit_tmpfile() Precedence: bulk X-Mailing-List: netfs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <303857.1728559382.1@warthog.procyon.org.uk> Date: Thu, 10 Oct 2024 12:23:02 +0100 Message-ID: <303858.1728559382@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Zizhi Wo wrote: > Currently, cachefiles_commit_tmpfile() will only be called if object->flags > is set to CACHEFILES_OBJECT_USING_TMPFILE. Only cachefiles_create_file() > and cachefiles_invalidate_cookie() set this flag. Both of these functions > replace object->file with the new tmpfile, and both are called by > fscache_cookie_state_machine(), so there are no concurrency issues. > > So the equation "d_backing_inode(dentry) == file_inode(object->file)" in > cachefiles_commit_tmpfile() will never hold true according to the above > conditions. This patch removes this part of the redundant code and does not > involve any other logical changes. > > Signed-off-by: Zizhi Wo Yeah, that's reasonable - and if it did hold true, all we do is unlink and relink it. Acked-by: David Howells