From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D21191C6F4B for ; Thu, 10 Oct 2024 11:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728560232; cv=none; b=PsWqr5EeOmJ+jFEooAqfAd8y7MeqxZOWxZLW8GITgaSHH30lc43syGu55LcYeSE23hi0KSfFLIZ74wLdCjSMQrtHsbpUFsGEthHOQhj5ffumlttrI/G0oM1Ul+BisF4+75hb43hDjLco0PJmt1AVvDPwCzQirMBd3+YYX86iff0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728560232; c=relaxed/simple; bh=7muf9vDPJHKAd2mvKg8YJK84HnrdBqeO6Zqe4jEU3is=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=sdMBaZokcFPX7UiDaETLBMXC4sUGGBYHxOKImM3faNf+A6NJ0PCi8zgkeKRoPhbK0+R6FfGWdQRziF13PaVShQmoAr9hgcbnQTIKLdXWHJ8A7hwMlUDPBOtXIIuluGs4ZtfCq5/kMGP9Ok91QZMkHNDbD9RrHNxF7eFI9+YUStM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IsP02Lk+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IsP02Lk+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728560229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7muf9vDPJHKAd2mvKg8YJK84HnrdBqeO6Zqe4jEU3is=; b=IsP02Lk+KfQb5t1Xq2Y2eWW6TQo2zC2bEKr3aDzggBHoMY6Mm9TUltk0zzk6mw3GnrL76W Qdi3NVjHdgUvXyIyEj6Z4LDoSiJRI5y5Lb7P5hs8NW+T1YESqWorq9s9y76lDkx9ml0XG1 u4dMkQun58pfhZPFsXkLoHzCx48mcj0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-zaMNslEuNF-beVOermW28w-1; Thu, 10 Oct 2024 07:37:04 -0400 X-MC-Unique: zaMNslEuNF-beVOermW28w-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 243EC1955EA5; Thu, 10 Oct 2024 11:37:02 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 34F1019560A3; Thu, 10 Oct 2024 11:36:57 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20240821024301.1058918-2-wozizhi@huawei.com> <20240821024301.1058918-1-wozizhi@huawei.com> <302546.1728556499@warthog.procyon.org.uk> To: Zizhi Wo Cc: dhowells@redhat.com, netfs@lists.linux.dev, jlayton@kernel.org, hsiangkao@linux.alibaba.com, jefflexu@linux.alibaba.com, zhujia.zj@bytedance.com, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, libaokun1@huawei.com, yangerkun@huawei.com, houtao1@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH 1/8] cachefiles: Fix incorrect block calculations in __cachefiles_prepare_write() Precedence: bulk X-Mailing-List: netfs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <304310.1728560215.1@warthog.procyon.org.uk> Date: Thu, 10 Oct 2024 12:36:55 +0100 Message-ID: <304311.1728560215@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Zizhi Wo wrote: > For scenarios such as nfs/cifs, the corresponding bsize is PAGE_SIZE aligned cache->bsize is a property of the cache device, not the network filesystems that might be making use of it (and it might be shared between multiple volumes from multiple network filesystems, all of which could, in theory, have different 'block sizes', inasmuch as network filesystems have block sizes). David