From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C110298CC4 for ; Mon, 24 Nov 2025 19:56:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764014204; cv=none; b=awt3plVcDN/EOfB3nwa8kHawOUgGNtakfwEycXBr7//LKvdj2+W8xE8i/eqtzJRsiTopLbk5ZJYF/vomlFPciEi4EgzWLV+ZRQvRc56twF4LvOoQdKCxKSBZU7e8WFoui0y9acb96fPaUYre4c3RGpUVmK6voeM5hesyhYL4JUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764014204; c=relaxed/simple; bh=mOFz3pDbIikoGojeagVAUflzKKEym12vWvlNpcvFY40=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=rxrihUKP0b9tWKexK1Q80hY75ASpmyNvwa+0FIcEEyBU9vCOJU2klxSzmqT1I5eYvMI8bETfJokZHXlM352jKNdLGLFRDU5kW8UgPmyNLO6sbvzSg3yhD6laIsif56MAMqd+B2wTm6rlp9gJu51XWgJLHRc7qfGuUf8MJ8zXues= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PpzvWuO/; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PpzvWuO/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764014201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JWTHDWixO/WvuzV14DS/uqZIEULkQGQzdbnhW5iVDYU=; b=PpzvWuO//MTRxKniFuFfP8/ZsNi2Pm6IxZQYNTTxpBG4k/Fx+5G4tkQKdt/z4ot/vHI8ax hevdnZUpv1v81CMtVZ3rrQqq9I5lj9ppA9li2xR+43HNRy3mHk2+JgvJQ2Ktdi+J3VOnM4 Vib0Q19ZxowySuAJLhNjXkTinMkAGWU= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-cVU6EIuhOZymMOv5hBRUZw-1; Mon, 24 Nov 2025 14:56:39 -0500 X-MC-Unique: cVU6EIuhOZymMOv5hBRUZw-1 X-Mimecast-MFC-AGG-ID: cVU6EIuhOZymMOv5hBRUZw_1764014198 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 90DFA1954B0D; Mon, 24 Nov 2025 19:56:37 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.14]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 47227180047F; Mon, 24 Nov 2025 19:56:35 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20251124124251.3565566-1-dhowells@redhat.com> <20251124124251.3565566-6-dhowells@redhat.com> To: Tom Talpey Cc: dhowells@redhat.com, Steve French , Paulo Alcantara , Shyam Prasad N , Stefan Metzmacher , linux-cifs@vger.kernel.org, netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 05/11] cifs: Remove the RFC1002 header from smb_hdr Precedence: bulk X-Mailing-List: netfs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3649835.1764014194.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Mon, 24 Nov 2025 19:56:34 +0000 Message-ID: <3649836.1764014194@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Tom Talpey wrote: > On 11/24/2025 7:42 AM, David Howells wrote: > > Remove the RFC1002 header from struct smb_hdr as used for SMB-1.0. Th= is > > simplifies the SMB-1.0 code by simplifying a lot of places that have t= o add > > or subtract 4 to work around the fact that the RFC1002 header isn't re= ally > > part of the message and the base for various offsets within the messag= e is > > from the base of the smb_hdr, not the RFC1002 header. > = > This is truly great, RFC1002 is a framing layer and separating it from > the upper SMB code is long overdue. > = > But... isn't this applicable to SMB2/3? The commit log implies it's SMB1 > only (nit there's no such thing as "SMB-1.0"), which is weird given the > commit applies to many smb2 files. SMB2/3 doesn't have the RFC1002 headers included in struct smb2_hdr, presumably because of the compound chaining, so nothing needed doing in th= at respect. This harmonises SMB1 with SMB2/3. > And, are similar changes envisioned in the ksmbd code? None required AFAIK as that doesn't support SMB1? David