From: David Howells <dhowells@redhat.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: dhowells@redhat.com, netfs@lists.linux.dev,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] netfs: Fix a few minor bugs in netfs_page_mkwrite()
Date: Mon, 07 Oct 2024 15:14:18 +0100 [thread overview]
Message-ID: <4027713.1728310458@warthog.procyon.org.uk> (raw)
In-Reply-To: <20241005182307.3190401-3-willy@infradead.org>
Matthew Wilcox (Oracle) <willy@infradead.org> wrote:
> We can't return with VM_FAULT_SIGBUS | VM_FAULT_LOCKED; the core
> code will not unlock the folio in this instance. Introduce a new
> "unlock" error exit to handle this case. Use it to handle
> the "folio is truncated" check, and change the "writeback interrupted
> by a fatal signal" to do a NOPAGE exit instead of letting the core
> code install the folio currently under writeback before killing the
> process.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Fixes: 102a7e2c598c ("netfs: Allow buffered shared-writeable mmap through netfs_page_mkwrite()")
Acked-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2024-10-07 14:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 18:23 [PATCH 0/3] Random netfs folio fixes Matthew Wilcox (Oracle)
2024-10-05 18:23 ` [PATCH 1/3] netfs: Remove call to folio_index() Matthew Wilcox (Oracle)
2024-10-07 14:13 ` David Howells
2024-10-05 18:23 ` [PATCH 2/3] netfs: Fix a few minor bugs in netfs_page_mkwrite() Matthew Wilcox (Oracle)
2024-10-07 14:14 ` David Howells [this message]
2024-10-05 18:23 ` [PATCH 3/3] netfs: Remove unnecessary references to pages Matthew Wilcox (Oracle)
2024-10-07 14:14 ` David Howells
2024-10-07 11:46 ` [PATCH 0/3] Random netfs folio fixes Christian Brauner
2024-10-07 14:15 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4027713.1728310458@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox