From: Baokun Li <libaokun@huaweicloud.com>
To: David Howells <dhowells@redhat.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-erofs@lists.ozlabs.org, Jeff Layton <jlayton@kernel.org>,
stable@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Christian Brauner <brauner@kernel.org>,
Gao Xiang <hsiangkao@linux.alibaba.com>,
Hou Tao <houtao1@huawei.com>,
Jingbo Xu <jefflexu@linux.alibaba.com>,
Yang Erkun <yangerkun@huawei.com>, Yu Kuai <yukuai3@huawei.com>,
Zizhi Wo <wozizhi@huawei.com>,
Baokun Li <libaokun@huaweicloud.com>
Subject: Re: [PATCH] cachefiles: fix dentry leak in cachefiles_open_file()
Date: Thu, 29 Aug 2024 09:43:23 +0800 [thread overview]
Message-ID: <491c1962-1f9e-4aca-b263-eb6eb88140e0@huaweicloud.com> (raw)
In-Reply-To: <1043618.1724861676@warthog.procyon.org.uk>
Hi David,
On 2024/8/29 0:14, David Howells wrote:
> Baokun Li <libaokun@huaweicloud.com> wrote:
>
>>> You couldn't do that anyway, since kernel_file_open() steals the caller's ref
>>> if successful.
>> Ignoring kernel_file_open(), we now put a reference count of the dentry
>> whether cachefiles_open_file() returns true or false.
> Actually, I'm wrong kernel_file_open() doesn't steal a ref.
>
> David
>
>
Thanks for confirming this.
I will send a new version using the new solution.
Cheers,
Baokun
prev parent reply other threads:[~2024-08-29 1:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 4:00 [PATCH] cachefiles: fix dentry leak in cachefiles_open_file() libaokun
2024-08-26 13:55 ` Markus Elfring
2024-08-27 3:47 ` Baokun Li
2024-08-27 8:34 ` Markus Elfring
2024-08-28 13:01 ` [PATCH] " David Howells
2024-08-28 14:05 ` Baokun Li
2024-08-28 16:14 ` David Howells
2024-08-29 1:43 ` Baokun Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491c1962-1f9e-4aca-b263-eb6eb88140e0@huaweicloud.com \
--to=libaokun@huaweicloud.com \
--cc=Markus.Elfring@web.de \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=houtao1@huawei.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=jefflexu@linux.alibaba.com \
--cc=jlayton@kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=stable@kernel.org \
--cc=wozizhi@huawei.com \
--cc=yangerkun@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox