public inbox for netfs@lists.linux.dev
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: dhowells@redhat.com, Steve French <sfrench@samba.org>,
	Paulo Alcantara <pc@manguebit.org>,
	Shyam Prasad N <sprasad@microsoft.com>,
	Stefan Metzmacher <metze@samba.org>, Tom Talpey <tom@talpey.com>,
	linux-cifs@vger.kernel.org, netfs@lists.linux.dev,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/9] cifs: Remove the RFC1002 header from smb_hdr
Date: Thu, 18 Dec 2025 13:36:16 +0000	[thread overview]
Message-ID: <611045.1766064976@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAKYAXd9Ju4MFkkH5Jxfi1mO0AWEr=R35M3vQ_Xa7Yw34JoNZ0A@mail.gmail.com>

Namjae Jeon <linkinjeon@kernel.org> wrote:

> Why did you only change smb client after changing smb_hdr structure in
> smb/common?  smb server also uses smb_hdr structure to handle smb1 negotiate
> request.

Apologies, but I was under the impression from Steve that ksmbd didn't support
SMB1 and was never going to.  Further, I'm pretty certain I have been building
the server and it hasn't shown up any errors - and Steve hasn't mentioned any
either.

> Also, Why didn't you cc me on the patch that updates smb/common?

You're not mentioned in the MAINTAINERS record for CIFS.  I did, however, send
it to the linux-cifs mailing list six times, though.

David



  reply	other threads:[~2025-12-18 13:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-01 22:57 [PATCH v6 0/9] cifs: Miscellaneous prep patches for rewrite of I/O layer David Howells
2025-12-01 22:57 ` [PATCH v6 1/9] cifs: Remove the RFC1002 header from smb_hdr David Howells
2025-12-18 12:17   ` Namjae Jeon
2025-12-18 13:36     ` David Howells [this message]
2025-12-18 15:17       ` Namjae Jeon
2025-12-01 22:57 ` [PATCH v6 2/9] cifs: Make smb1's SendReceive() wrap cifs_send_recv() David Howells
2025-12-01 22:57 ` [PATCH v6 3/9] cifs: Clean up some places where an extra kvec[] was required for rfc1002 David Howells
2025-12-01 22:57 ` [PATCH v6 4/9] cifs: Replace SendReceiveBlockingLock() with SendReceive() plus flags David Howells
2025-12-01 22:57 ` [PATCH v6 5/9] cifs: Fix specification of function pointers David Howells
2025-12-01 22:57 ` [PATCH v6 6/9] cifs: Remove the server pointer from smb_message David Howells
2025-12-01 22:57 ` [PATCH v6 7/9] cifs: Don't need state locking in smb2_get_mid_entry() David Howells
2025-12-01 22:57 ` [PATCH v6 8/9] cifs: Add a tracepoint to log EIO errors David Howells
2025-12-01 22:57 ` [PATCH v6 9/9] cifs: Do some preparation prior to organising the function declarations David Howells
2025-12-02  1:04 ` [PATCH v6 0/9] cifs: Miscellaneous prep patches for rewrite of I/O layer Steve French
2025-12-02  7:15   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=611045.1766064976@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=metze@samba.org \
    --cc=netfs@lists.linux.dev \
    --cc=pc@manguebit.org \
    --cc=sfrench@samba.org \
    --cc=sprasad@microsoft.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox