From: David Howells <dhowells@redhat.com>
To: NeilBrown <neil@brown.name>
Cc: dhowells@redhat.com, "Marc Dionne" <marc.c.dionne@gmail.com>,
"Paulo Alcantara" <pc@manguebit.org>,
"Christian Brauner" <brauner@kernel.org>,
netfs@lists.linux.dev, linux-afs@lists.infradead.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cachefiles: Fix excess dput() after end_removing()
Date: Thu, 26 Mar 2026 16:04:00 +0000 [thread overview]
Message-ID: <682795.1774541040@warthog.procyon.org.uk> (raw)
In-Reply-To: <177451605242.1851489.9347587959983302502@noble.neil.brown.name>
NeilBrown <neilb@ownmail.net> wrote:
> - ret = cachefiles_bury_object(cache, NULL, dir, victim,
> + ret = cachefiles_bury_object(cache, NULL, dir, dget(victim),
I would prefer the dget() to be on a line on its own before this one to make
it easier to spot.
> If you agree I can post a properly formated patch which explanation.
That would be great!
Thanks,
David
next prev parent reply other threads:[~2026-03-26 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 22:35 [PATCH] cachefiles: Fix excess dput() after end_removing() David Howells
2026-03-24 22:50 ` David Howells
2026-03-25 12:57 ` Marc Dionne
2026-03-26 7:51 ` David Howells
2026-03-26 9:07 ` NeilBrown
2026-03-26 16:04 ` David Howells [this message]
2026-03-26 10:15 ` [PATCH v2] " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=682795.1774541040@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=brauner@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.c.dionne@gmail.com \
--cc=neil@brown.name \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox