From: David Howells <dhowells@redhat.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: dhowells@redhat.com, netfs@lists.linux.dev
Subject: Re: [bug report] netfs: Speed up buffered reading
Date: Wed, 11 Sep 2024 10:22:01 +0100 [thread overview]
Message-ID: <755884.1726046521@warthog.procyon.org.uk> (raw)
In-Reply-To: <6caf8f55-4eeb-4ada-8ecf-9c92ce83f40b@stanley.mountain>
Dan Carpenter <dan.carpenter@linaro.org> wrote:
> 107 if (WARN_ON_ONCE(!folioq) ||
> ^^^^^^^
> Check for NULL
>
> 108 WARN_ON_ONCE(!folioq_folio(folioq, slot)) ||
> 109 WARN_ON_ONCE(folioq_folio(folioq, slot)->index != fpos / PAGE_SIZE)) {
None of these three conditions should be true - and if they are, the operation
is broken. We cannot find the pages we need to unlock and processes will very
likely hang.
David
next prev parent reply other threads:[~2024-09-11 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 7:36 [bug report] netfs: Speed up buffered reading Dan Carpenter
2024-09-11 9:22 ` David Howells [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-09-11 7:36 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=755884.1726046521@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dan.carpenter@linaro.org \
--cc=netfs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox