netfs.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Mateusz Guzik <mjguzik@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Max Kellermann <max.kellermann@ionos.com>,
	slava.dubeyko@ibm.com, xiubli@redhat.com,  idryomov@gmail.com,
	amarkuze@redhat.com, ceph-devel@vger.kernel.org,
	 netfs@lists.linux.dev, linux-kernel@vger.kernel.org,
	 linux-fsdevel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ceph: fix deadlock bugs by making iput() calls asynchronous
Date: Thu, 18 Sep 2025 01:08:29 +0200	[thread overview]
Message-ID: <CAGudoHHb38eeqPdwjBpkweEwsa6_DTvdrXr2jYmcJ7h2EpMyQg@mail.gmail.com> (raw)
In-Reply-To: <aMs7WYubsgGrcSXB@dread.disaster.area>

On Thu, Sep 18, 2025 at 12:51 AM Dave Chinner <david@fromorbit.com> wrote:
> - wait for Josef to finish his inode refcount rework patchset that
>   gets rid of this whole "writeback doesn't hold an inode reference"
>   problem that is the root cause of this the deadlock.
>
> All that adding a whacky async iput work around does right now is
> make it harder for Josef to land the patchset that makes this
> problem go away entirely....
>

Per Max this is a problem present on older kernels as well, something
of this sort is needed to cover it regardless of what happens in
mainline.

As for mainline, I don't believe Josef's patchset addresses the problem.

The newly added refcount now taken by writeback et al only gates the
inode getting freed, it does not gate almost any of iput/evict
processing. As in with the patchset writeback does not hold a real
reference.

So ceph can still iput from writeback and find itself waiting in
inode_wait_for_writeback, unless the filesystem can be converted to
use the weaker refcounts and iobj_put instead (but that's not
something I would be betting on).

  reply	other threads:[~2025-09-17 23:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17 12:44 [PATCH] ceph: fix deadlock bugs by making iput() calls asynchronous Max Kellermann
2025-09-17 13:13 ` Mateusz Guzik
2025-09-17 13:22   ` Mateusz Guzik
2025-09-17 13:23   ` Max Kellermann
2025-09-17 13:39   ` Max Kellermann
2025-09-17 13:45     ` Mateusz Guzik
2025-09-17 22:51 ` Dave Chinner
2025-09-17 23:08   ` Mateusz Guzik [this message]
2025-09-18  0:04     ` Mateusz Guzik
2025-09-18  1:51       ` Dave Chinner
2025-09-19 16:41         ` Mateusz Guzik
2025-09-18  1:07     ` Dave Chinner
2025-09-18  4:43   ` Max Kellermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGudoHHb38eeqPdwjBpkweEwsa6_DTvdrXr2jYmcJ7h2EpMyQg@mail.gmail.com \
    --to=mjguzik@gmail.com \
    --cc=amarkuze@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=david@fromorbit.com \
    --cc=idryomov@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max.kellermann@ionos.com \
    --cc=netfs@lists.linux.dev \
    --cc=slava.dubeyko@ibm.com \
    --cc=stable@vger.kernel.org \
    --cc=xiubli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).