From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: David Howells <dhowells@redhat.com>,
Leon Romanovsky <leonro@nvidia.com>,
Christian Brauner <christian@brauner.io>,
Chuck Lever <chuck.lever@oracle.com>,
Steve French <smfrench@gmail.com>,
Ilya Dryomov <idryomov@gmail.com>,
netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] iov_iter: Add composite, scatterlist and skbuff iterator types
Date: Sun, 23 Mar 2025 14:33:39 +0000 [thread overview]
Message-ID: <Z-AbwwTtfpKr_pgY@casper.infradead.org> (raw)
In-Reply-To: <Z9-oaC3lVIMQ4rUF@infradead.org>
On Sat, Mar 22, 2025 at 11:21:28PM -0700, Christoph Hellwig wrote:
> This is going entirely in the wrong direction. We don't need more iter
> types but less. The reason why we have to many is because the underlying
> representation of the ranges is a mess which goes deeper than just the
> iterator, because it also means we have to convert between the
> underlying representations all the time.
>
> E.g. the socket code should have (and either has for a while or at least
> there were patches) been using bio_vecs instead of reinventing them as sk
> fragment. The crypto code should not be using scatterlists, which are a
I did this work six years ago -- see 8842d285bafa
Unfortunately, networking is full of inconsiderate arseholes who backed
it out without even talking to me in 21d2e6737c97
prev parent reply other threads:[~2025-03-23 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 16:14 [RFC PATCH 0/4] iov_iter: Add composite, scatterlist and skbuff iterator types David Howells
2025-03-21 16:14 ` [RFC PATCH 1/4] iov_iter: Move ITER_DISCARD and ITER_XARRAY iteration out-of-line David Howells
2025-03-21 16:14 ` [RFC PATCH 2/4] iov_iter: Add an iterator-of-iterators David Howells
2025-03-21 16:14 ` [RFC PATCH 3/4] iov_iter: Add a scatterlist iterator type David Howells
2025-03-21 16:14 ` [RFC PATCH 4/4] iov_iter: Add a scatterlist iterator type [INCOMPLETE] David Howells
2025-03-23 6:21 ` [RFC PATCH 0/4] iov_iter: Add composite, scatterlist and skbuff iterator types Christoph Hellwig
2025-03-23 13:39 ` Hannes Reinecke
2025-03-23 14:35 ` Matthew Wilcox
2025-03-23 14:33 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-AbwwTtfpKr_pgY@casper.infradead.org \
--to=willy@infradead.org \
--cc=christian@brauner.io \
--cc=chuck.lever@oracle.com \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=idryomov@gmail.com \
--cc=leonro@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netfs@lists.linux.dev \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).