From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC1CF2206A8 for ; Thu, 9 Jan 2025 15:45:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736437540; cv=none; b=QyvUzixxBkbe4qAsWYlTU4rgGUwKJWflOV1DzuXeL0MGVuc9osZk+tXWXkr6vWMSzwZg79FdqRY7sVwh1jwzn1Z67JW2T3ZJFbkDvLkEpjYwpheGKGf4rWpyFIh7ErGFpZ56Wq/xgDiZVav8yXbxJQ277sxdMOfFqznoJcvmQSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736437540; c=relaxed/simple; bh=2brKe+BKxputZorOKd+f+yIxImiCIbAyHwtB6oU0kzg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JwBNBA1p+pI76DGf8x85BgSDdtg/tnv9cai1p2Xo3SpbzXiSOcXJnhxqLARyMbc3L9DtFZycCj0NztAy/Jn3ZS5cz5UajfwOqag8Y0Z1J+bQz7r/nrMC2Pm/hxJWTrthLhpRZwkXXj9St/+/Pr0bvKlpvcrvhwAJhe6cPqAa5mA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=minyard.net; spf=none smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard-net.20230601.gappssmtp.com header.i=@minyard-net.20230601.gappssmtp.com header.b=rYLNYmIO; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard-net.20230601.gappssmtp.com header.i=@minyard-net.20230601.gappssmtp.com header.b="rYLNYmIO" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-721d213e2aeso270503a34.3 for ; Thu, 09 Jan 2025 07:45:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard-net.20230601.gappssmtp.com; s=20230601; t=1736437536; x=1737042336; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=cgTp2x21PamB5G5tjbV3jPSQRWSgTUkiJmrzV93coW4=; b=rYLNYmIOYvmfXmb+zRNgk72s6dfB5y4ZIRNc14R669pb+t8WZYEzkglRpVpDxf74D9 DIWZrBQBGjGAnbS93fhlEpO6IwPYwxUgw+To5Z94cH8ahbZ4mPguwfXF3cE7w4ivHhjt d2Js+SPDp+6hPKABNO+383lKTACGdIJR+LS1P0gePPIfj+nCOxCTeXslb4H5SZacBrhr c6o3j2EMFKO39AK8Cf63onrMoyFJ3HqamZjPUyGkShJzYBsKPPtpZcFnsLnZMLF/gWw2 JHgKPNSVlRLxMsbODSJPtWzuNVweOTsXh/2xeCptvV/+VgkqPII5bJDSJqv8LK1bJsGK IYNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736437536; x=1737042336; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cgTp2x21PamB5G5tjbV3jPSQRWSgTUkiJmrzV93coW4=; b=J5HpZYzgmiznM/D6zjuH2X2QQMXwL76FIVuNEzOYJ0MuDfPlcwbShSKSB0Y3oYpfOM Ckan2nMxik2Vco1HvKnpTFnn83QPCsG9Z89F6LXf8tVNfVab/VRdXLPYWtwkoqb56qRE +HKAZzctl+qE/9boyXM1oBDPVgHKhUpwqlCbJ0i3Idop7Glc+EWPlu3xMplZDD2wgFis Qns+9u/6BtU7F2/0wpP5DNoaDT+/Uv/uTLWkFebfBQlkgc2Kdd2ll4MMnJJUZV9gcm5F bbNNYOJiTJYzyBVrs7CDJMUssENvuDz9BnzHH/YUzbqpzAB2F04F0X3EiJONCQe3dfrw vqjw== X-Forwarded-Encrypted: i=1; AJvYcCV0QufI4c3+eCxDIPapkd4wSDEEXLbPnXKvBz4WWJzk/u4oNiUdw14K69rMY/89huZm/jYSCw==@lists.linux.dev X-Gm-Message-State: AOJu0YwBXQRPLpUWHSWxO2P9h423VVhkLu7Iq/V8gsOLOQnlYAoebN+w Vn+QKTzpHRM1oTECTat1PJvjpH9bfqpzNMMRdwjWZXDUA3rXs+8dB/BJkqC8RfM= X-Gm-Gg: ASbGncu6AtAxQ/2pMKjLlJCjT31li6N7TIf6twCbe1amq8kgY67JQwmWQltbKtAMnzY VYdGYHCn1mCCOMtJLqKG0Vn8hnZDzahTnA6P89uhmQr9ht36GhoHVXk7tcmRIBszg2XIISUF5oZ b1wglgjLW1kUcqUYxnevgkviokfOhfbKysdzwg78wWWjgg7QdxY3wIvftCoevGc4OS4WmD8oaiG oMTt1jWAcFSlKDPWlEChkZ4vYN4pc3F5mVAZIVESqC9A6e9M+jh+nCXsSj1 X-Google-Smtp-Source: AGHT+IHELUnxP9ZvL+e2Ztemz39I9ORoPYZLTVwEa+XG73J5uz7w7yM0cuXu9KZqTaUsGk+1/+jmGA== X-Received: by 2002:a05:6830:6610:b0:716:a95d:9ef with SMTP id 46e09a7af769-721e2e000d6mr4949630a34.2.1736437534534; Thu, 09 Jan 2025 07:45:34 -0800 (PST) Received: from mail.minyard.net ([2001:470:b8f6:1b:9076:47eb:1e0a:16fb]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5f882625f0esm386258eaf.9.2025.01.09.07.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 07:45:34 -0800 (PST) Date: Thu, 9 Jan 2025 09:45:27 -0600 From: Corey Minyard To: Joel Granados Cc: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Kees Cook , Luis Chamberlain , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, openipmi-developer@lists.sourceforge.net, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org, linux-raid@vger.kernel.org, linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org, xen-devel@lists.xenproject.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev, codalist@coda.cs.cmu.edu, linux-mm@kvack.org, linux-nfs@vger.kernel.org, ocfs2-devel@lists.linux.dev, fsverity@lists.linux.dev, linux-xfs@vger.kernel.org, io-uring@vger.kernel.org, bpf@vger.kernel.org, kexec@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH] treewide: const qualify ctl_tables where applicable Message-ID: Reply-To: corey@minyard.net References: <20250109-jag-ctl_table_const-v1-1-622aea7230cf@kernel.org> Precedence: bulk X-Mailing-List: netfs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250109-jag-ctl_table_const-v1-1-622aea7230cf@kernel.org> On Thu, Jan 09, 2025 at 02:16:39PM +0100, Joel Granados wrote: > Add the const qualifier to all the ctl_tables in the tree except the > ones in ./net dir. The "net" sysctl code is special as it modifies the > arrays before passing it on to the registration function. > ... > diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c > index 941d2dcc8c9d..de84f59468a9 100644 > --- a/drivers/char/ipmi/ipmi_poweroff.c > +++ b/drivers/char/ipmi/ipmi_poweroff.c > @@ -650,7 +650,7 @@ static struct ipmi_smi_watcher smi_watcher = { > #ifdef CONFIG_PROC_FS > #include > > -static struct ctl_table ipmi_table[] = { > +static const struct ctl_table ipmi_table[] = { > { .procname = "poweroff_powercycle", > .data = &poweroff_powercycle, > .maxlen = sizeof(poweroff_powercycle), For the IPMI portion: Acked-by: Corey Minyard