From: Dominique Martinet <asmadeus@codewreck.org>
To: David Howells <dhowells@redhat.com>
Cc: Christian Brauner <brauner@kernel.org>,
Christian Schoenebeck <linux_oss@crudebyte.com>,
Eric Van Hensbergen <ericvh@kernel.org>,
Latchesar Ionkov <lucho@ionkov.net>,
Chris Arges <carges@cloudflare.com>,
Matthew Wilcox <willy@infradead.org>,
Steve French <sfrench@samba.org>,
v9fs@lists.linux.dev, netfs@lists.linux.dev,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfs: Fix early read unlock of page with EOF in middle
Date: Sun, 21 Dec 2025 08:54:21 +0900 [thread overview]
Message-ID: <aUc3Lcy_u4FgnwjA@codewreck.org> (raw)
In-Reply-To: <8618918.T7Z3S40VBb@weasel>
Christian Schoenebeck wrote on Sat, Dec 20, 2025 at 03:55:09PM +0100:
> I had bisected this mmap() data corruption to e2d46f2ec332 ("netfs: Change the
> read result collector to only use one work item"). So maybe adding a Fixes:
> tag for this as suggested by Dominique?
Yes, I had also confirmed the bug starts occuring since that commit (and
the fix works on that point in the tree as well), please add:
Fixes: e2d46f2ec332 ("netfs: Change the read result collector to only use one work item")
That aside, your commit message looks good to me:
Acked-by: Dominique Martinet <asmadeus@codewreck.org>
Thank you for having taken the time to look at it!
--
Dominique Martinet | Asmadeus
next prev parent reply other threads:[~2025-12-20 23:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 12:31 [PATCH] netfs: Fix early read unlock of page with EOF in middle David Howells
2025-12-20 14:55 ` Christian Schoenebeck
2025-12-20 15:17 ` David Howells
2025-12-20 23:50 ` Christian Schoenebeck
2025-12-20 23:54 ` Dominique Martinet [this message]
2025-12-24 12:31 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUc3Lcy_u4FgnwjA@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=brauner@kernel.org \
--cc=carges@cloudflare.com \
--cc=dhowells@redhat.com \
--cc=ericvh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=netfs@lists.linux.dev \
--cc=sfrench@samba.org \
--cc=v9fs@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox