From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31607209F4E; Thu, 20 Mar 2025 10:46:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742467594; cv=none; b=tAAR/DaYcN15CVIJ4d+jc9x+GpqNEsEhCuNoMkZytcg8Lx6WfzXbwHNoqnWrU0e23h7KPwFJhbZJ5Ca6XoV7UCxGmUGr6sjo2uze0tjzB1UTo1tYqYuD/3DnVCK4mLWnI8p1CwUINw1zfvA5k3Yq7yPBX56T7tTmRe3dUh+OgUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742467594; c=relaxed/simple; bh=YvMQlYXlkwRZkEReaqyNkiXw7BWYWP12LN8EdzHzpsU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=eDeC7JaZRov4gzVUPy0PgTxKCQIjtI0NMT3xBaCPbJZUx0pQnt8ClncwHm7wPCmncLu+ll+2m7Z+XXPX7lr2csj3fwma+35d4XFOTXmqOetHya4Cow0LlHz3B66l7MfBwOfl9y8UJB3qF149FaR4oJxDBKRcHlOV96jTZWjEHIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gi4Ey/7Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gi4Ey/7Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2273C4CEEC; Thu, 20 Mar 2025 10:46:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742467593; bh=YvMQlYXlkwRZkEReaqyNkiXw7BWYWP12LN8EdzHzpsU=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=gi4Ey/7ZG9i4OVoCYEMtLOriw101iUKTiHUW4fze1MmUgdWAA/dxjnp2cJc5pTBUb teJL+hCQKNeg9PmJGsYy2W9yuNnaAEUORZnKYVx5p7BxIUY2ogPXGw+EdCI1EK28Jp XgPnhb8kH/upO8Bp6TEe0gk4Fvt0a3wHg/Q5OzrRO+eBrU0FzgEnrbVe3MWZTOps1P oEg+Lp+0tQle42tW4nb3ugOmbz+rUuXMuogZLcDPO/bhDKcuss59/Pduv2cBr/OpIw hkJFhyy9fnKiDFAsZJyU5d67NlrwL8XStoASxu/5nyIPLrB4/e9Gjw0bwQ8Dpr2J+W 69mFeb2UkR28Q== Message-ID: Subject: Re: [PATCH 6/6] VFS: change lookup_one_common and lookup_noperm_common to take a qstr From: Jeff Layton To: NeilBrown , Alexander Viro , Christian Brauner , Jan Kara , David Howells , Chuck Lever Cc: linux-nfs@vger.kernel.org, netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org Date: Thu, 20 Mar 2025 06:46:31 -0400 In-Reply-To: <20250319031545.2999807-7-neil@brown.name> References: <20250319031545.2999807-1-neil@brown.name> <20250319031545.2999807-7-neil@brown.name> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) Precedence: bulk X-Mailing-List: netfs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2025-03-19 at 14:01 +1100, NeilBrown wrote: > From: NeilBrown >=20 > These function already take a qstr of course, but they also currently > take a name/len was well and fill in the qstr. > Now they take a qstr that is already filled in, which is what all the > callers have. >=20 > Signed-off-by: NeilBrown > --- > fs/namei.c | 44 +++++++++++++++++++------------------------- > 1 file changed, 19 insertions(+), 25 deletions(-) >=20 > diff --git a/fs/namei.c b/fs/namei.c > index 16605f7108c0..e2fb61573f13 100644 > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -2833,13 +2833,12 @@ int vfs_path_lookup(struct dentry *dentry, struct= vfsmount *mnt, > } > EXPORT_SYMBOL(vfs_path_lookup); > =20 > -static int lookup_noperm_common(const char *name, struct dentry *base, > - int len, > - struct qstr *this) > +static int lookup_noperm_common(struct qstr *qname, struct dentry *base) > { > - this->name =3D name; > - this->len =3D len; > - this->hash =3D full_name_hash(base, name, len); > + const char *name =3D qname->name; > + u32 len =3D qname->len; > + > + qname->hash =3D full_name_hash(base, name, len); > if (!len) > return -EACCES; > =20 > @@ -2856,7 +2855,7 @@ static int lookup_noperm_common(const char *name, s= truct dentry *base, > * to use its own hash.. > */ > if (base->d_flags & DCACHE_OP_HASH) { > - int err =3D base->d_op->d_hash(base, this); > + int err =3D base->d_op->d_hash(base, qname); > if (err < 0) > return err; > } > @@ -2864,10 +2863,10 @@ static int lookup_noperm_common(const char *name,= struct dentry *base, > } > =20 > static int lookup_one_common(struct mnt_idmap *idmap, > - const char *name, struct dentry *base, int len, > - struct qstr *this) { > + struct qstr *qname, struct dentry *base) > +{ > int err; > - err =3D lookup_noperm_common(name, base, len, this); > + err =3D lookup_noperm_common(qname, base); > if (err < 0) > return err; > return inode_permission(idmap, base->d_inode, MAY_EXEC); > @@ -2888,16 +2887,14 @@ static int lookup_one_common(struct mnt_idmap *id= map, > */ > struct dentry *try_lookup_noperm(struct qstr *name, struct dentry *base) > { > - struct qstr this; > int err; > =20 > WARN_ON_ONCE(!inode_is_locked(base->d_inode)); > =20 > - err =3D lookup_noperm_common(name->name, base, name->len, &this); > + err =3D lookup_noperm_common(name, base); > if (err) > return ERR_PTR(err); > =20 > - name->hash =3D this.hash; > return lookup_dcache(name, base, 0); > } > EXPORT_SYMBOL(try_lookup_noperm); > @@ -2915,17 +2912,16 @@ EXPORT_SYMBOL(try_lookup_noperm); > struct dentry *lookup_noperm(struct qstr name, struct dentry *base) > { > struct dentry *dentry; > - struct qstr this; > int err; > =20 > WARN_ON_ONCE(!inode_is_locked(base->d_inode)); > =20 > - err =3D lookup_noperm_common(name.name, base, name.len, &this); > + err =3D lookup_noperm_common(&name, base); > if (err) > return ERR_PTR(err); > =20 > - dentry =3D lookup_dcache(&this, base, 0); > - return dentry ? dentry : __lookup_slow(&this, base, 0); > + dentry =3D lookup_dcache(&name, base, 0); > + return dentry ? dentry : __lookup_slow(&name, base, 0); > } > EXPORT_SYMBOL(lookup_noperm); > =20 > @@ -2943,17 +2939,16 @@ struct dentry *lookup_one(struct mnt_idmap *idmap= , struct qstr name, > struct dentry *base) > { > struct dentry *dentry; > - struct qstr this; > int err; > =20 > WARN_ON_ONCE(!inode_is_locked(base->d_inode)); > =20 > - err =3D lookup_one_common(idmap, name.name, base, name.len, &this); > + err =3D lookup_one_common(idmap, &name, base); > if (err) > return ERR_PTR(err); > =20 > - dentry =3D lookup_dcache(&this, base, 0); > - return dentry ? dentry : __lookup_slow(&this, base, 0); > + dentry =3D lookup_dcache(&name, base, 0); > + return dentry ? dentry : __lookup_slow(&name, base, 0); > } > EXPORT_SYMBOL(lookup_one); > =20 > @@ -2971,17 +2966,16 @@ EXPORT_SYMBOL(lookup_one); > struct dentry *lookup_one_unlocked(struct mnt_idmap *idmap, > struct qstr name, struct dentry *base) > { > - struct qstr this; > int err; > struct dentry *ret; > =20 > - err =3D lookup_one_common(idmap, name.name, base, name.len, &this); > + err =3D lookup_one_common(idmap, &name, base); > if (err) > return ERR_PTR(err); > =20 > - ret =3D lookup_dcache(&this, base, 0); > + ret =3D lookup_dcache(&name, base, 0); > if (!ret) > - ret =3D lookup_slow(&this, base, 0); > + ret =3D lookup_slow(&name, base, 0); > return ret; > } > EXPORT_SYMBOL(lookup_one_unlocked); Reviewed-by: Jeff Layton