From: Jeff Layton <jlayton@kernel.org>
To: yangerkun <yangerkun@huawei.com>,
dhowells@redhat.com, hsiangkao@linux.alibaba.com,
netfs@lists.linux.dev
Subject: Re: [PATCH] netfs: fix the mismatch used for CONFIG_FSCACHE_DEBUG
Date: Sat, 23 Mar 2024 11:57:16 -0400 [thread overview]
Message-ID: <f62d83b5baa4b92ab3681671e6964b2b73ec9e31.camel@kernel.org> (raw)
In-Reply-To: <20240323092312.1643320-1-yangerkun@huawei.com>
On Sat, 2024-03-23 at 17:23 +0800, yangerkun wrote:
> The name of debug config used in fs/netfs/internal.h has a mismatch
> compared to the define in fs/netfs/Kconfig, which lead to that debug for
> netfs won't work.
>
> Signed-off-by: yangerkun <yangerkun@huawei.com>
> ---
> fs/netfs/internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/netfs/internal.h b/fs/netfs/internal.h
> index ec7045d24400..53d61ead35fd 100644
> --- a/fs/netfs/internal.h
> +++ b/fs/netfs/internal.h
> @@ -349,7 +349,7 @@ void fscache_create_volume(struct fscache_volume *volume, bool wait);
> #define _leave(FMT, ...) kleave(FMT, ##__VA_ARGS__)
> #define _debug(FMT, ...) kdebug(FMT, ##__VA_ARGS__)
>
> -#elif defined(CONFIG_NETFS_DEBUG)
> +#elif defined(CONFIG_FSCACHE_DEBUG)
> #define _enter(FMT, ...) \
> do { \
> if (netfs_debug) \
Nice catch!
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2024-03-23 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 9:23 [PATCH] netfs: fix the mismatch used for CONFIG_FSCACHE_DEBUG yangerkun
2024-03-23 15:57 ` Jeff Layton [this message]
2024-03-24 16:13 ` Gao Xiang
2024-04-24 11:17 ` yangerkun
2024-08-19 11:28 ` David Howells
2024-08-19 11:36 ` yangerkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f62d83b5baa4b92ab3681671e6964b2b73ec9e31.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=dhowells@redhat.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=netfs@lists.linux.dev \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox