From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F1FFCCD19F for ; Mon, 20 Oct 2025 23:44:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE1D710E0DA; Mon, 20 Oct 2025 23:44:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="eAAimqfx"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 917C210E0DA; Mon, 20 Oct 2025 23:44:50 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 9F0FE602F0; Mon, 20 Oct 2025 23:44:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DA3AC4CEFB; Mon, 20 Oct 2025 23:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761003889; bh=ErnMc4zfx6Bt1UKhR4J5JkX5muJWOlmyUseeP5/tWtw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eAAimqfxlfQsE0eGwPHFXR/+HG/Yc8+ijhBPSbQAlE/j1yRwkdCqoEgGwyPAJlPRH +xLSqo9Oyd6sPdJSuYGMYtb6kTtV/4NEw2qx2zXVC/2KTrEX4zfAFFyQiISUHIzAqa q+W+gJdEeMW/58t8BdPexfKsWvhgnqsPv43w4cwH1DTNhGMspB57SPppK0gq+CxtPR 0oIG/kjbN5aE/uaXNE5Id4whpGTj3dotEVPddn9quwHKj5d3W/MILkyiNo9th+vOrm YLMIVyUTQ/uxbibrq0raEntSp22AHKJIulGH9nQ/NiEsJBhEQ3HLvIUBWAaVGOgLth sspme8NV03kyg== Message-ID: <059912ef-6023-4af4-a8df-f4b34fe98e71@kernel.org> Date: Tue, 21 Oct 2025 01:44:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7.1 0/4] bitfield initial refactor within nova-core (RESEND) To: Alexandre Courbot Cc: Joel Fernandes , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, dri-devel@lists.freedesktop.org, Alistair Popple , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , bjorn3_gh@protonmail.com, Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , John Hubbard , Timur Tabi , joel@joelfernandes.org, Elle Rhumsaa , Yury Norov , Daniel Almeida , nouveau@lists.freedesktop.org References: <20251016151323.1201196-1-joelagnelf@nvidia.com> From: Danilo Krummrich Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On 10/18/25 3:41 PM, Alexandre Courbot wrote: > On Fri Oct 17, 2025 at 12:13 AM JST, Joel Fernandes wrote: >> (Resending due to some commit message mistakes (missing SOB etc). Thanks!). >> >> These patches implement the initial refactoring and few improvements to the >> register and bitfield macros. Rebased on drm-rust-next. >> >> Main difference from the previous series [1] is dropped the moving out of >> nova-core pending BoundedInt changes: >> https://lore.kernel.org/all/20251003154748.1687160-1-joelagnelf@nvidia.com/ >> Other than that, added tags, resolved conflict with kernel::fmt changes and >> rebased on drm-rust-next. > > Thanks, this version is looking pretty good, and works as intended. > > I plan on pushing these 4 patches soonish after fixing the line length > issues and the other few problems reported by checkpatch. > > Danilo, please let me know if you think this is premature, but imho it > is good to set this part in stone to avoid merge conflicts with future > patches that will want to modify the register macro. SGTM, we can keep discussing the hi:lo ascending / descending topic for nova-core independently. However, for the sample code that, eventually, we'll move out of nova-core, we should stick to what's common. With that, Acked-by: Danilo Krummrich