From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] drm: remove unneeded break Date: Sun, 8 Nov 2020 18:59:45 +0100 Message-ID: <20201108175945.GA1508644@ravnborg.org> References: <20201019163115.25814-1-trix@redhat.com> <20201019170641.GA963808@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20201019170641.GA963808@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: trix@redhat.com Cc: airlied@linux.ie, nouveau@lists.freedesktop.org, gustavoars@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, tzimmermann@suse.de, airlied@redhat.com, spice-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, bskeggs@redhat.com List-Id: nouveau.vger.kernel.org Hi Tom On Mon, Oct 19, 2020 at 07:06:41PM +0200, Sam Ravnborg wrote: > Hi Tom > On Mon, Oct 19, 2020 at 09:31:15AM -0700, trix@redhat.com wrote: > > From: Tom Rix > > > > A break is not needed if it is preceded by a return or break > > > > Signed-off-by: Tom Rix > > Looks good and builds with no warnings. > > One of the diffs made me - "oh this looks wrong". But after I looked again > it was right and the resulting code is more readable - so good. > > Acked-by: Sam Ravnborg > > Was tempted to just apply to drm-misc-next but will give others the > opportunity to chime in. Thanks. Now applied to drm-misc-next - will show up in -next in a week or so. Sam