From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 037EFCCA472 for ; Mon, 6 Oct 2025 20:57:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B2E210E5E5; Mon, 6 Oct 2025 20:57:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=permerror (0-bit key) header.d=gmail.com header.i=@gmail.com header.b="iCyK85vJ"; dkim-atps=neutral Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id C1B8C10E93C for ; Thu, 25 Sep 2025 13:54:48 +0000 (UTC) Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-78ed682e9d3so7145206d6.0 for ; Thu, 25 Sep 2025 06:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758808488; x=1759413288; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BVNYKpGpulAPMt7+7S4cKU51h0g+oImaV0zrihGhT7E=; b=iCyK85vJ8yv3hJ190Kgh5vwrUdLze5zqZug9unjWfyuHpCdUEORSwOVgTMBxr3fl2G PaqsRY49bzM1Dt9Fh+n6BHmeb67IKURRzCUHPwRjTbf3dwtAcWCONpWRKo3Tv+f4ASPI TfEEDDB8cs6yS+tKU8u4lvyJ8ZhEgYvxSgzksftkCPtjIWhzAj8QTEl3d8YqL64G7Ani QXSDJMOQGAYwNexK97viLEnUZyEwZxyBEw6hLSwBInIoCMONy7rdJ2Hdlt/q67AUXiMF By/G6dpHyISBK1WWYtE7Kx9YIgIYxaljTJ7M78ajG78sHSUAq1umUKPra5aIdU3EOQsQ xpbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758808488; x=1759413288; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BVNYKpGpulAPMt7+7S4cKU51h0g+oImaV0zrihGhT7E=; b=SnOeYuC5YiVScxXMLgNN0t3kO/PINx/A57nElh30f5r8itAW6l9n1+8YX28rc5+zh3 O7fmOS4yZrabpZ3VPPu+emrMKYrspJFgbQEzsG5EGo0gzx3MzKNr/wdGDJOPi/chJjeh NCUD1dhUhW29ORXSBv19EQAMbAiHUtzIQxK7roxovyGemoGPyluHeqP+IgzrEn4B8bJb yDj0CoC4+VmFir+CaGpeuKi7kVhCI9U9JlLXh9ZOjf5LEzX03YUS8rjXp4EslG2cg6mg imMKCB6bGRXk0243C78dO/ZfkFZ3l8SABNmTJoAVfxHtJXS4Xc7FUEyzjPvFQXOF7xoX bIlg== X-Forwarded-Encrypted: i=1; AJvYcCXvyiI5NxONHFxkWYj4NQP4BvidWvvx21wMP5ikdJUVBHC60zIfftliNyTEAFZa0A9xDwrmUd8p@lists.freedesktop.org X-Gm-Message-State: AOJu0YwNvaOJzzdE3tJxnAoIQ8r+3DGdjOPccQgHaly1TwwBKm/ojfBl gPlS9l1Fev7pCpBq4VWIX9qN7sDGfeH5LRqRwkI/JljjO6c3vATpboJu X-Gm-Gg: ASbGnctqU8z9pQaHKiPzz2ctrnkR2zfYYa91R3MTcoDa8WSQxzWGLBkbj3V+bZj6hJq r/khE63wPic7woY7LVO9ykZ2b/f8rLUhQCaJf6I15My7cIw+Dsd+FRlwgXUWAs4O76bv2BMBjQX tp4lEySWi0c+Syl4TFEIHvYzEQSIICEkpb03Qr+ZnpZA6TDw6ARUzUxWzBJ3lD9Q7QdQOTevJ/w TBS+toTYLGKwKJoj1l+nl8ocn8NnXxRZrrTncUjYlcLx0iTS/ABilzOmQO38nABc4kEFZqtAKOK kYbxuJs90biEJiM8PbcV+YyVrvBbjOegh1IqzcZywrZKmc30aKXjsbEfHPs5VUYLZFQDSWLIP5m 0EzSMR2OSi91aZ1uAYHvigpZScCBRbVJsatXYBH7Rfr06K3dMKredlMgJ/N/F5kjU7e4DW4Ybfv AHWzo1XjXJg0hhktvsn8fSpGBgSzLBxbx5AF2PuPWkxwUnJTAaIEWW7EAq3hAuDWwT4uIL X-Google-Smtp-Source: AGHT+IGcSCDHxLWEAv2+tvuTndpWh14kIE0XwxqS1qORz7M/FkaXk4hS2hKSF3fui4XqH/sHYATWuw== X-Received: by 2002:a05:6214:c87:b0:77e:443f:dfab with SMTP id 6a1803df08f44-7fc3bf7dbbfmr47922816d6.32.1758808487268; Thu, 25 Sep 2025 06:54:47 -0700 (PDT) Received: from 137.1.168.192.in-addr.arpa ([2600:4808:6353:5c00:7c:b286:dba3:5ba8]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-80135968d5esm11536916d6.12.2025.09.25.06.54.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Sep 2025 06:54:46 -0700 (PDT) From: Tamir Duberstein Date: Thu, 25 Sep 2025 09:53:53 -0400 Subject: [PATCH v2 05/19] rust: configfs: replace `kernel::c_str!` with C-Strings MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250925-core-cstr-cstrings-v2-5-78e0aaace1cd@gmail.com> References: <20250925-core-cstr-cstrings-v2-0-78e0aaace1cd@gmail.com> In-Reply-To: <20250925-core-cstr-cstrings-v2-0-78e0aaace1cd@gmail.com> To: "Rafael J. Wysocki" , Viresh Kumar , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , FUJITA Tomonori , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michael Turquette , Stephen Boyd , Breno Leitao , Greg Kroah-Hartman , Luis Chamberlain , Russ Weight , Dave Ertman , Ira Weiny , Leon Romanovsky , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Arnd Bergmann , Brendan Higgins , David Gow , Rae Moar , Jens Axboe , Alexandre Courbot , Alexander Viro , Christian Brauner , Jan Kara , Liam Girdwood , Mark Brown Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-clk@vger.kernel.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1758808437; l=3197; i=tamird@gmail.com; h=from:subject:message-id; bh=JsC9L09JB7c5Qto+RbQqrQ01xP/c2mn8RT/NxDHSNBk=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QCiWFaUQLEh7L6qOIxKWop5VB/xMpVQ3YvBt09OraNycfeOEzMuEQ7DscsvKM0CSzPbqArJQKNv 7EXOamgAaLgc= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc X-Mailman-Approved-At: Mon, 06 Oct 2025 20:57:16 +0000 X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" C-String literals were added in Rust 1.77. Replace instances of `kernel::c_str!` with C-String literals where possible. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Signed-off-by: Tamir Duberstein Acked-by: Andreas Hindborg --- rust/kernel/configfs.rs | 9 +++++---- samples/rust/rust_configfs.rs | 5 ++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/rust/kernel/configfs.rs b/rust/kernel/configfs.rs index 9fb5ef825e41..69bb1fb53543 100644 --- a/rust/kernel/configfs.rs +++ b/rust/kernel/configfs.rs @@ -21,7 +21,6 @@ //! //! ```ignore //! use kernel::alloc::flags; -//! use kernel::c_str; //! use kernel::configfs_attrs; //! use kernel::configfs; //! use kernel::new_mutex; @@ -50,7 +49,7 @@ //! //! try_pin_init!(Self { //! config <- configfs::Subsystem::new( -//! c_str!("rust_configfs"), item_type, Configuration::new() +//! c"rust_configfs", item_type, Configuration::new() //! ), //! }) //! } @@ -66,7 +65,7 @@ //! impl Configuration { //! fn new() -> impl PinInit { //! try_pin_init!(Self { -//! message: c_str!("Hello World\n"), +//! message: c"Hello World\n", //! bar <- new_mutex!((KBox::new([0; PAGE_SIZE], flags::GFP_KERNEL)?, 0)), //! }) //! } @@ -1000,7 +999,9 @@ macro_rules! configfs_attrs { static [< $data:upper _ $name:upper _ATTR >]: $crate::configfs::Attribute<$attr, $data, $data> = unsafe { - $crate::configfs::Attribute::new(c_str!(::core::stringify!($name))) + $crate::configfs::Attribute::new( + $crate::c_str!(::core::stringify!($name)), + ) }; )* diff --git a/samples/rust/rust_configfs.rs b/samples/rust/rust_configfs.rs index 5005453f874d..ea84c23b784b 100644 --- a/samples/rust/rust_configfs.rs +++ b/samples/rust/rust_configfs.rs @@ -3,7 +3,6 @@ //! Rust configfs sample. use kernel::alloc::flags; -use kernel::c_str; use kernel::configfs; use kernel::configfs_attrs; use kernel::new_mutex; @@ -35,7 +34,7 @@ struct Configuration { impl Configuration { fn new() -> impl PinInit { try_pin_init!(Self { - message: c_str!("Hello World\n"), + message: c"Hello World\n", bar <- new_mutex!((KBox::new([0; PAGE_SIZE], flags::GFP_KERNEL)?, 0)), }) } @@ -61,7 +60,7 @@ fn init(_module: &'static ThisModule) -> impl PinInit { try_pin_init!(Self { config <- configfs::Subsystem::new( - c_str!("rust_configfs"), item_type, Configuration::new() + c"rust_configfs", item_type, Configuration::new() ), }) } -- 2.51.0