public inbox for nouveau@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Subject: nouveau : fix r570 suspend/resume regression
Date: Tue,  3 Feb 2026 15:21:10 +1000	[thread overview]
Message-ID: <20260203052431.2219998-1-airlied@gmail.com> (raw)

Since R570 firmware got enabled, a number of GPUs have not being
successfully suspend/resuming. Lyude showed it on RTX6000, which
I reproduced and wasted a lot of time down various rabbit holes.

There are two required fixes, the first one adds proper sequence
numbers to the rpc messages, which fixes a bunch of NOCAT asserts.

Then we have to pass the runtime vs non-runtime state down to the
GSP fbsr code. This however requires replacing a bool with an enum
which refactors quite a bunch of interfaces unfortunately, but it
was the cleanest way to do it.

The final patch hooks up the interface so normal suspend doesn't
set the GCOFF flags.

Dave.


             reply	other threads:[~2026-02-03  5:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03  5:21 Dave Airlie [this message]
2026-02-03  5:21 ` [PATCH 1/3] nouveau/gsp: use rpc sequence numbers properly Dave Airlie
2026-02-04 21:36   ` Timur Tabi
2026-02-04 21:56     ` Dave Airlie
2026-02-05  3:00       ` John Hubbard
2026-02-05  4:37         ` Dave Airlie
2026-02-05  5:39           ` John Hubbard
2026-02-03  5:21 ` [PATCH 2/3] nouveau: add a third state to the fini handler Dave Airlie
2026-02-03  5:21 ` [PATCH 3/3] nouveau/gsp: fix suspend/resume regression on r570 firmware Dave Airlie
2026-02-03 20:08 ` nouveau : fix r570 suspend/resume regression lyude
2026-02-04  3:06   ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260203052431.2219998-1-airlied@gmail.com \
    --to=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox