Re: [PATCH v2 8/8] gpu: nova-core: convert to new dma::Coherent API

Gary Guo
2026-03-21T22:37:09Z

On Sat Mar 21, 2026 at 6:22 PM GMT, Danilo Krummrich wrote:
> On 3/21/26 5:50 PM, Gary Guo wrote:
> > It looks like with Alex's "gpu: nova-core: create falcon firmware DMA objects
> > lazily" landed, all others users of the old API are now gone.
>
> Good catch.
>
> > So this line could be dropped and `impl CoherentAllocation` and the type alias
> > can be removed after this patch.
>
> I will drop the line on apply and add the below patch to remove
> CoherentAllocation.
>
> - Danilo
>
> commit e96bc0b65bec48ac0f1cf2fc15b39c1b26b9d973 (HEAD -> drm-rust-next)
> Author: Danilo Krummrich <dakr@kernel.org>
> Date: Sat Mar 21 19:18:08 2026 +0100
>
> rust: dma: remove dma::CoherentAllocation<T>
>
> Now that everything has been converted to the new dma::Coherent<T> API,
> remove dma::CoherentAllocation<T>.
>
> Suggested-by: Gary Guo <gary@garyguo.net>
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>

Reviewed-by: Gary Guo <gary@garyguo.net>