* [PATCH] gpu: nova-core: fix missing colon in SEC2 boot debug message
@ 2026-03-31 10:37 David Carlier
2026-03-31 19:19 ` John Hubbard
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: David Carlier @ 2026-03-31 10:37 UTC (permalink / raw)
To: Danilo Krummrich, Alice Ryhl, Alexandre Courbot, David Airlie,
Simona Vetter, Gary Guo, Alistair Popple, Eliot Courtney,
John Hubbard, Timur Tabi, nouveau
Cc: David Carlier
The SEC2 mailbox debug output formats MBOX1 without a colon separator,
producing "MBOX10xdead" instead of "MBOX1: 0xdead". The GSP debug
message a few lines above uses the correct format.
Fixes: 5949d419c193 ("gpu: nova-core: gsp: Boot GSP")
Signed-off-by: David Carlier <devnexen@gmail.com>
---
drivers/gpu/nova-core/gsp/boot.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/boot.rs
index 6f707b3d1a54..18f356c9178e 100644
--- a/drivers/gpu/nova-core/gsp/boot.rs
+++ b/drivers/gpu/nova-core/gsp/boot.rs
@@ -195,7 +195,7 @@ pub(crate) fn boot(
Some(wpr_handle as u32),
Some((wpr_handle >> 32) as u32),
)?;
- dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n", mbox0, mbox1);
+ dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1: {:#x}\n", mbox0, mbox1);
if mbox0 != 0 {
dev_err!(pdev, "Booter-load failed with error {:#x}\n", mbox0);
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] gpu: nova-core: fix missing colon in SEC2 boot debug message
2026-03-31 10:37 [PATCH] gpu: nova-core: fix missing colon in SEC2 boot debug message David Carlier
@ 2026-03-31 19:19 ` John Hubbard
2026-04-04 2:19 ` Alexandre Courbot
2026-04-06 1:17 ` Alexandre Courbot
2 siblings, 0 replies; 5+ messages in thread
From: John Hubbard @ 2026-03-31 19:19 UTC (permalink / raw)
To: David Carlier, Danilo Krummrich, Alice Ryhl, Alexandre Courbot,
David Airlie, Simona Vetter, Gary Guo, Alistair Popple,
Eliot Courtney, Timur Tabi, nouveau
On 3/31/26 3:37 AM, David Carlier wrote:
> The SEC2 mailbox debug output formats MBOX1 without a colon separator,
> producing "MBOX10xdead" instead of "MBOX1: 0xdead". The GSP debug
> message a few lines above uses the correct format.
>
> Fixes: 5949d419c193 ("gpu: nova-core: gsp: Boot GSP")
> Signed-off-by: David Carlier <devnexen@gmail.com>
> ---
> drivers/gpu/nova-core/gsp/boot.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/boot.rs
> index 6f707b3d1a54..18f356c9178e 100644
> --- a/drivers/gpu/nova-core/gsp/boot.rs
> +++ b/drivers/gpu/nova-core/gsp/boot.rs
> @@ -195,7 +195,7 @@ pub(crate) fn boot(
> Some(wpr_handle as u32),
> Some((wpr_handle >> 32) as u32),
> )?;
> - dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n", mbox0, mbox1);
> + dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1: {:#x}\n", mbox0, mbox1);
This is also fixed in my Blackwell series, see patch 28/31 [1].
[1] https://lore.kernel.org/20260326013902.588242-29-jhubbard@nvidia.com
thanks,
--
John Hubbard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gpu: nova-core: fix missing colon in SEC2 boot debug message
2026-03-31 10:37 [PATCH] gpu: nova-core: fix missing colon in SEC2 boot debug message David Carlier
2026-03-31 19:19 ` John Hubbard
@ 2026-04-04 2:19 ` Alexandre Courbot
2026-04-04 9:37 ` Danilo Krummrich
2026-04-06 1:17 ` Alexandre Courbot
2 siblings, 1 reply; 5+ messages in thread
From: Alexandre Courbot @ 2026-04-04 2:19 UTC (permalink / raw)
To: David Carlier, Danilo Krummrich
Cc: Danilo Krummrich, Alice Ryhl, Simona Vetter, Gary Guo,
Alistair Popple, Eliot Courtney, nouveau
On Tue Mar 31, 2026 at 7:37 PM JST, David Carlier wrote:
> The SEC2 mailbox debug output formats MBOX1 without a colon separator,
> producing "MBOX10xdead" instead of "MBOX1: 0xdead". The GSP debug
> message a few lines above uses the correct format.
>
> Fixes: 5949d419c193 ("gpu: nova-core: gsp: Boot GSP")
> Signed-off-by: David Carlier <devnexen@gmail.com>
> ---
> drivers/gpu/nova-core/gsp/boot.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/boot.rs
> index 6f707b3d1a54..18f356c9178e 100644
> --- a/drivers/gpu/nova-core/gsp/boot.rs
> +++ b/drivers/gpu/nova-core/gsp/boot.rs
> @@ -195,7 +195,7 @@ pub(crate) fn boot(
> Some(wpr_handle as u32),
> Some((wpr_handle >> 32) as u32),
> )?;
> - dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n", mbox0, mbox1);
> + dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1: {:#x}\n", mbox0, mbox1);
>
> if mbox0 != 0 {
> dev_err!(pdev, "Booter-load failed with error {:#x}\n", mbox0);
> --
> 2.53.0
Thanks for the patch! The issue is also technically fixed by [1] but I
prefer having one fix per patch, so thinking about taking it anyway.
Danilo, do you mind if I fast-track this one into drm-rust-next since it
introduces no possibility of breakage and is technically a fix? This
would allow the Blackwell series to rebase nicely.
[1] https://lore.kernel.org/all/20260326013902.588242-29-jhubbard@nvidia.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gpu: nova-core: fix missing colon in SEC2 boot debug message
2026-04-04 2:19 ` Alexandre Courbot
@ 2026-04-04 9:37 ` Danilo Krummrich
0 siblings, 0 replies; 5+ messages in thread
From: Danilo Krummrich @ 2026-04-04 9:37 UTC (permalink / raw)
To: Alexandre Courbot
Cc: David Carlier, Alice Ryhl, Simona Vetter, Gary Guo,
Alistair Popple, Eliot Courtney, nouveau
On Sat Apr 4, 2026 at 4:19 AM CEST, Alexandre Courbot wrote:
> On Tue Mar 31, 2026 at 7:37 PM JST, David Carlier wrote:
>> The SEC2 mailbox debug output formats MBOX1 without a colon separator,
>> producing "MBOX10xdead" instead of "MBOX1: 0xdead". The GSP debug
>> message a few lines above uses the correct format.
>>
>> Fixes: 5949d419c193 ("gpu: nova-core: gsp: Boot GSP")
>> Signed-off-by: David Carlier <devnexen@gmail.com>
>> ---
>> drivers/gpu/nova-core/gsp/boot.rs | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/boot.rs
>> index 6f707b3d1a54..18f356c9178e 100644
>> --- a/drivers/gpu/nova-core/gsp/boot.rs
>> +++ b/drivers/gpu/nova-core/gsp/boot.rs
>> @@ -195,7 +195,7 @@ pub(crate) fn boot(
>> Some(wpr_handle as u32),
>> Some((wpr_handle >> 32) as u32),
>> )?;
>> - dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n", mbox0, mbox1);
>> + dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1: {:#x}\n", mbox0, mbox1);
>>
>> if mbox0 != 0 {
>> dev_err!(pdev, "Booter-load failed with error {:#x}\n", mbox0);
>> --
>> 2.53.0
>
> Thanks for the patch! The issue is also technically fixed by [1] but I
> prefer having one fix per patch, so thinking about taking it anyway.
>
> Danilo, do you mind if I fast-track this one into drm-rust-next since it
> introduces no possibility of breakage and is technically a fix? This
> would allow the Blackwell series to rebase nicely.
I don't mind if we end up picking your v5 of the UB fix in the next days, so it
is still in time for another drm-rust-next PR before the merge window opens.
Otherwise, I wouldn't send a PR just for this.
> [1] https://lore.kernel.org/all/20260326013902.588242-29-jhubbard@nvidia.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gpu: nova-core: fix missing colon in SEC2 boot debug message
2026-03-31 10:37 [PATCH] gpu: nova-core: fix missing colon in SEC2 boot debug message David Carlier
2026-03-31 19:19 ` John Hubbard
2026-04-04 2:19 ` Alexandre Courbot
@ 2026-04-06 1:17 ` Alexandre Courbot
2 siblings, 0 replies; 5+ messages in thread
From: Alexandre Courbot @ 2026-04-06 1:17 UTC (permalink / raw)
To: David Carlier
Cc: Danilo Krummrich, Alice Ryhl, Simona Vetter, Gary Guo,
Alistair Popple, Eliot Courtney, nouveau
On Tue Mar 31, 2026 at 7:37 PM JST, David Carlier wrote:
> The SEC2 mailbox debug output formats MBOX1 without a colon separator,
> producing "MBOX10xdead" instead of "MBOX1: 0xdead". The GSP debug
> message a few lines above uses the correct format.
>
> Fixes: 5949d419c193 ("gpu: nova-core: gsp: Boot GSP")
> Signed-off-by: David Carlier <devnexen@gmail.com>
> ---
> drivers/gpu/nova-core/gsp/boot.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/boot.rs
> index 6f707b3d1a54..18f356c9178e 100644
> --- a/drivers/gpu/nova-core/gsp/boot.rs
> +++ b/drivers/gpu/nova-core/gsp/boot.rs
> @@ -195,7 +195,7 @@ pub(crate) fn boot(
> Some(wpr_handle as u32),
> Some((wpr_handle >> 32) as u32),
> )?;
> - dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n", mbox0, mbox1);
> + dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1: {:#x}\n", mbox0, mbox1);
>
> if mbox0 != 0 {
> dev_err!(pdev, "Booter-load failed with error {:#x}\n", mbox0);
> --
> 2.53.0
As agreed upon with Danilo, pushed into drm-rust-next! Thanks for the fix.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-04-06 1:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-31 10:37 [PATCH] gpu: nova-core: fix missing colon in SEC2 boot debug message David Carlier
2026-03-31 19:19 ` John Hubbard
2026-04-04 2:19 ` Alexandre Courbot
2026-04-04 9:37 ` Danilo Krummrich
2026-04-06 1:17 ` Alexandre Courbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox