From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 103CEC43458 for ; Thu, 2 Jul 2026 13:13:23 +0000 (UTC) Received: from kara.freedesktop.org (unknown [131.252.210.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id B63C110F39C; Thu, 2 Jul 2026 13:13:21 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.b="jHDhEc6C"; dkim-atps=neutral Received: from kara.freedesktop.org (localhost [127.0.0.1]) by kara.freedesktop.org (Postfix) with ESMTP id 40E1046E65; Thu, 2 Jul 2026 12:58:35 +0000 (UTC) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=lists.freedesktop.org; s=20240201; t=1782997115; b=oaAbgdeF7K08Dg3Nb1ObZNpzmQaAWfOBPNs73dWKl2qCo/3qFFDYI0pqcB6mFduIhYO0R cc3vHFGSwezxK9uCIBd7YOsWx3U9SdocEJxDxZipqgtXdnA+6jntXbSe9/ZxsxcjJHGT29x K7//weTK4gPQGWqCVN95d+WATAHV11pfVJO02LCmwBv/4gkVby8uskH9VlEfFm8mJ97sc8C Fh1eFzwpQ3Wy+vC07yvkd3Xscw5m7gqb9zCsbxbErchRz5SsYzuoLs8Hq229Fsn2eRXLwVD DSX5d7xFmZHkKKCcwU4xR4uNWsi75ymkotWDFQg36Rzgv1gKwWk6+1Wiqs0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.freedesktop.org; s=20240201; t=1782997115; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=3WkYIESER5H1pxokBfEp6m9xEZZ5ghGe4TjZZy4BO5I=; b=hxH33e7PY3MrlEo3TiXiqYGPdVQBMglmLkhWbUZUgh/5qCGspj+2KVTAW+vPxdRSIDcb4 roAbck73G05UghXmGP6YaqymWIZKBuZx9K5Vf6W+shc89k+K1HWm1E/akwDRGfgPoRyO2Hp s+idC/xLmt3Nwau5ANn311VVY5Qzt7QdhLMTgV9Q2cXiMO7Ozj+ORK5LNEUN4un6Y6XKp4e Pz0Fl6v1S84UBW3M/lhS4FGdIVjfONlmg0swkC5/qetM6jj9iwxA7rggk1C89ka+hdiSN3d ezJTGIzJBp1N80OlPkkQtIfJGs9AAuQxScKql/w1flDWkDy7CssPdvcZXBPQ== ARC-Authentication-Results: i=1; mail.freedesktop.org; dkim=pass header.d=linux.dev; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=linux.dev policy.dmarc=none Authentication-Results: mail.freedesktop.org; dkim=pass header.d=linux.dev; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=linux.dev policy.dmarc=none Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by kara.freedesktop.org (Postfix) with ESMTPS id 69B8046E3B for ; Thu, 2 Jul 2026 12:58:32 +0000 (UTC) Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B63710F391 for ; Thu, 2 Jul 2026 13:13:18 +0000 (UTC) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782997985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3WkYIESER5H1pxokBfEp6m9xEZZ5ghGe4TjZZy4BO5I=; b=jHDhEc6CTiPftGqyHzVdl3xS/wEnOHSN4PeeVFnRX9fUml//8WA53GAPbsxSbJvWuzc/sf tH1rSEqcTxDFS7qyJ0iIaX/a6tA48FPP/mFE4c/byOkvPcPlvJwYSUFubJkz9Jxs6S5ya/ AItLuFoisprFM8kvEpkf04Kk84Cg/T0= From: Lance Yang To: ljs@kernel.org Subject: Re: [PATCH 10/13] mm/vma: convert miscellaneous uses of VMA flags in core mm Date: Thu, 2 Jul 2026 21:12:33 +0800 Message-Id: <20260702131233.59026-1-lance.yang@linux.dev> In-Reply-To: <1e7d834c887b6a65627d730addcff13d458c6268.1782760670.git.ljs@kernel.org> References: <1e7d834c887b6a65627d730addcff13d458c6268.1782760670.git.ljs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Message-ID-Hash: 26O2BNCYQV6HIV4V7IFVRWBPQI27JNXS X-Message-ID-Hash: 26O2BNCYQV6HIV4V7IFVRWBPQI27JNXS X-MailFrom: lance.yang@linux.dev X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: Nouveau development list Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Jun 29, 2026 at 08:25:33PM +0100, Lorenzo Stoakes wrote: >Update various uses of legacy flags in vma.c and mmap.c to the new >vma_flags_t type, updating comments alongside them to be consistent. > >Also update __install_special_mapping() to rearrange things slightly to >accommodate the changes. > >Signed-off-by: Lorenzo Stoakes >--- [...] >diff --git a/mm/vma.c b/mm/vma.c >index b81c05e67a61..ab2ef0f04420 100644 >--- a/mm/vma.c >+++ b/mm/vma.c >@@ -3417,23 +3417,27 @@ struct vm_area_struct *__install_special_mapping( > vm_flags_t vm_flags, void *priv, > const struct vm_operations_struct *ops) > { >- int ret; >+ vma_flags_t vma_flags = legacy_to_vma_flags(vm_flags); > struct vm_area_struct *vma; >+ int ret; > > vma = vm_area_alloc(mm); >- if (unlikely(vma == NULL)) >+ if (unlikely(!vma)) > return ERR_PTR(-ENOMEM); > >- vma_set_range(vma, addr, addr + len, 0); >- vm_flags |= vma_flags_to_legacy(mm->def_vma_flags) | VM_DONTEXPAND; >+ vma_flags_set_mask(&vma_flags, mm->def_vma_flags); >+ vma_flags_set(&vma_flags, VMA_DONTEXPAND_BIT); > if (pgtable_supports_soft_dirty()) >- vm_flags |= VM_SOFTDIRTY; >- vm_flags_init(vma, vm_flags & ~VM_LOCKED_MASK); >+ vma_flags_set(&vma_flags, VMA_SOFTDIRTY_BIT); >+ vma_flags_clear_mask(&vma_flags, VMA_LOCKED_MASK); >+ vma->flags = vma_flags; Maybe worth a vma_flags_init() helper here to mirror vm_flags_init()? With this open-coded, we lose the soft-dirty WARN_ON_ONCE sanity check. Might be nicer to keep that check in one place ;) [...]