From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 4/4] radeon: fall back to ACPI EDID retrieval Date: Tue, 28 Jul 2020 08:50:56 +0200 Message-ID: <3c355e4d-b9ff-66b7-e9e3-86027deeba6d@amd.com> References: <20200727205357.27839-1-ddadap@nvidia.com> <20200727205357.27839-5-ddadap@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200727205357.27839-5-ddadap-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Daniel Dadap , dri-devel-PD4FTy7X32lNgt0PjOBp9/egYHeGw8Jk@public.gmane.org, intel-gfx-PD4FTy7X32lNgt0PjOBp9/egYHeGw8Jk@public.gmane.org, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, alexander.deucher-5C7GfCeVMHo@public.gmane.org, david1.zhou-5C7GfCeVMHo@public.gmane.org List-Id: nouveau.vger.kernel.org Am 27.07.20 um 22:53 schrieb Daniel Dadap: > Fall back to retrieving the EDID via the ACPI _DDC method, when present > for notebook internal panels, when retrieving BIOS-embedded EDIDs. > > Signed-off-by: Daniel Dadap > --- > drivers/gpu/drm/radeon/radeon_combios.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_combios.c b/drivers/gpu/drm/radeon/radeon_combios.c > index c3e49c973812..de801d9fca54 100644 > --- a/drivers/gpu/drm/radeon/radeon_combios.c > +++ b/drivers/gpu/drm/radeon/radeon_combios.c > @@ -401,9 +401,8 @@ bool radeon_combios_check_hardcoded_edid(struct radeon_device *rdev) > struct edid * > radeon_bios_get_hardcoded_edid(struct radeon_device *rdev) > { > - struct edid *edid; > - > if (rdev->mode_info.bios_hardcoded_edid) { > + struct edid *edid; That's an unrelated an incorrect style change. You need a blank line after declaration. > edid = kmalloc(rdev->mode_info.bios_hardcoded_edid_size, GFP_KERNEL); > if (edid) { > memcpy((unsigned char *)edid, > @@ -412,7 +411,8 @@ radeon_bios_get_hardcoded_edid(struct radeon_device *rdev) > return edid; > } > } > - return NULL; > + > + return drm_get_edid_acpi(); In general a good idea, but I'm wondering if we should really do this so unconditionally here. Regards, Christian. > } > > static struct radeon_i2c_bus_rec combios_setup_i2c_bus(struct radeon_device *rdev,