From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8DAACAC5BB for ; Wed, 1 Oct 2025 23:56:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6BF1810E515; Wed, 1 Oct 2025 23:56:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="OOJYzq/d"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20FDA10E515 for ; Wed, 1 Oct 2025 23:56:05 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 9D20743F29; Wed, 1 Oct 2025 23:56:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4126C4CEF1; Wed, 1 Oct 2025 23:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759362964; bh=ILkjc/XVyx6bQd0jLKnZzkgG0gPtYYukDOQdK37yZo4=; h=Date:From:Subject:Cc:To:References:In-Reply-To:From; b=OOJYzq/d9GisZWtqu9cNN5RFi3FocdFAYpWPhUh2NCuSnPRxyxBP3x1IHCSv1xUUO bEdCEO+Vas16q+omPselXFEFb7cDvooOz1rAbQ+RVKbWxndUsP+bl5lO+qL2GWdZj2 BjXO3hTDcObebkjFTKK88bDcGj8s3bmuYoV0OEuof03/1V62oXgDdHjY7JLxFRNpb2 TUyq4QuFJg+jmzmh/nCFYPF8j4dmmVDxY22+sKrV57gXwK6mg9TLKcbEunAjFk/sK8 Vwnx7glv/LyvQ/ISNgyKBbMKIYVYTHCIV/Pl61l1hsmjcgwqGmUWd2YWArY447pMg5 s7w45BbsVUyFg== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 02 Oct 2025 01:55:57 +0200 Message-Id: From: "Danilo Krummrich" Subject: Re: [PATCH 0/2] rust: pci: expose is_virtfn() and reject VFs in nova-core Cc: "Joel Fernandes" , "Zhi Wang" , "Alistair Popple" , "Alexandre Courbot" , "Timur Tabi" , "Surath Mitra" , "David Airlie" , "Simona Vetter" , "Bjorn Helgaas" , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "nouveau@lists.freedesktop.org" , "linux-pci@vger.kernel.org" , "rust-for-linux@vger.kernel.org" , "LKML" , "Jason Gunthorpe" , "Alex Williamson" To: "John Hubbard" References: <20250930220759.288528-1-jhubbard@nvidia.com> <1FA2746D-6F73-4D5A-A0DC-803D0563A5D7@nvidia.com> In-Reply-To: X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Thu Oct 2, 2025 at 1:51 AM CEST, John Hubbard wrote: > On 10/1/25 4:47 PM, Joel Fernandes wrote: >>> On Oct 1, 2025, at 7:00=E2=80=AFPM, John Hubbard = wrote: >>> =EF=BB=BFOn 10/1/25 3:52 PM, Danilo Krummrich wrote: >>>>> On Thu Oct 2, 2025 at 12:38 AM CEST, John Hubbard wrote: >>>>> On 10/1/25 6:52 AM, Zhi Wang wrote: >>>>>> On 1.10.2025 13.32, Danilo Krummrich wrote: >>>>>>> On Wed Oct 1, 2025 at 3:22 AM CEST, John Hubbard wrote: >>>>>>>> On 9/30/25 5:29 PM, Alistair Popple wrote: >>>>>>>>> On 2025-10-01 at 08:07 +1000, John Hubbard = wrote... >>>>> ... >> Here is my opinion and correct me if I missed something: >>=20 >> It feels premature to remove the option of nova-core binding to a VF, si= nce other options to disable auto probing do exist as Jason pointed out. >>=20 >> Taking a parallel with VFIO pass through for instance, the user already = has to do some diligence like preventing drivers from binding and then maki= ng vfio-pci bind to the device IDs. This case is similar though slightly di= fferent, but VFIO setup requires some configuration anyway so will it reall= y improve anything? >>=20 >> I quietly suggest holding on till there is a real need or we are sure no= va cannot bind to, or operate on a VF. This=20 > > I'm confident that nova-core cannot properly handle a VF with *today's* c= ode. > There is no expectation at all for a VF to show up--yet. > > Which is why I think it's appropriate to skip it right now. I agree with John. If a driver does not support a certain device, it is not the user's responsibility to prevent probing. Currently nova-core does not support VFs= , so it should never get probed for them in the first place.