Re: [PATCH v4 05/33] gpu: nova-core: factor .fwsignature* selection into a new get_gsp_sigs_section()

John Hubbard
2026-02-12T00:40:31Z

On 2/11/26 2:16 AM, Danilo Krummrich wrote:
> On Tue Feb 10, 2026 at 3:45 AM CET, John Hubbard wrote:
...
>> diff --git a/drivers/gpu/nova-core/firmware/gsp.rs b/drivers/gpu/nova-core/firmware/gsp.rs
>> index bc2243450989..10761716ed93 100644
>> --- a/drivers/gpu/nova-core/firmware/gsp.rs
>> +++ b/drivers/gpu/nova-core/firmware/gsp.rs
>> @@ -146,6 +146,36 @@ pub(crate) struct GspFirmware {
>> }
>>
>> impl GspFirmware {
>> + fn get_gsp_sigs_section(chipset: Chipset) -> Option<&'static str> {
>
> Please don't use the 'get' prefix, as it commonly indicates taking a reference
> count.
>
> Let's use something like find_gsp_sigs_section().

Done, thanks for catching that.

thanks,
--
John Hubbard