Re: [PATCH v4 27/33] gpu: nova-core: Hopper/Blackwell: larger WPR2 (GSP) heap

Danilo Krummrich
2026-02-17T20:10:45Z

On Tue Feb 10, 2026 at 3:45 AM CET, John Hubbard wrote:
> @@ -74,7 +94,7 @@ fn management_overhead(fb_size: u64) -> u64 {
> u64::from(bindings::GSP_FW_HEAP_PARAM_SIZE_PER_GB_FB)
> .saturating_mul(fb_size_gb)
> .align_up(GSP_HEAP_ALIGNMENT)
> - .unwrap_or(u64::MAX)
> + .expect("management_overhead alignment overflow")

Ultimately, the relevant value for this calculation (fb_size) comes from the
hardware through a register read if I'm not mistaken, we shouldn't panic on
that, but rather handle is as an error if the read value is not plausible.