Re: [PATCH] gpu: nova-core: fix missing colon in SEC2 boot debug message

["Danilo Krummrich" <dakr@kernel.org>]

On Sat Apr 4, 2026 at 4:19 AM CEST, Alexandre Courbot wrote:
> On Tue Mar 31, 2026 at 7:37 PM JST, David Carlier wrote:
>> The SEC2 mailbox debug output formats MBOX1 without a colon separator,
>> producing "MBOX10xdead" instead of "MBOX1: 0xdead". The GSP debug
>> message a few lines above uses the correct format.
>>
>> Fixes: 5949d419c193 ("gpu: nova-core: gsp: Boot GSP")
>> Signed-off-by: David Carlier <devnexen@gmail.com>
>> ---
>>  drivers/gpu/nova-core/gsp/boot.rs | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/boot.rs
>> index 6f707b3d1a54..18f356c9178e 100644
>> --- a/drivers/gpu/nova-core/gsp/boot.rs
>> +++ b/drivers/gpu/nova-core/gsp/boot.rs
>> @@ -195,7 +195,7 @@ pub(crate) fn boot(
>>              Some(wpr_handle as u32),
>>              Some((wpr_handle >> 32) as u32),
>>          )?;
>> -        dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n", mbox0, mbox1);
>> +        dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1: {:#x}\n", mbox0, mbox1);
>>  
>>          if mbox0 != 0 {
>>              dev_err!(pdev, "Booter-load failed with error {:#x}\n", mbox0);
>> -- 
>> 2.53.0
>
> Thanks for the patch! The issue is also technically fixed by [1] but I
> prefer having one fix per patch, so thinking about taking it anyway.
>
> Danilo, do you mind if I fast-track this one into drm-rust-next since it
> introduces no possibility of breakage and is technically a fix? This
> would allow the Blackwell series to rebase nicely.

I don't mind if we end up picking your v5 of the UB fix in the next days, so it
is still in time for another drm-rust-next PR before the merge window opens.

Otherwise, I wouldn't send a PR just for this.

> [1] https://lore.kernel.org/all/20260326013902.588242-29-jhubbard@nvidia.com/