public inbox for nouveau@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] Fix scdc implementation missing in GK208B NVidia Card (gk104_sor_hdmi)
@ 2026-01-17 14:15 Giuseppe Ranieri
  2026-01-19  8:12 ` Philipp Stanner
  0 siblings, 1 reply; 3+ messages in thread
From: Giuseppe Ranieri @ 2026-01-17 14:15 UTC (permalink / raw)
  To: nouveau


I fixed a problem for the GK208B NVidia Card (GT710): 
the initialization was broken my card support scdc channel but the implementation was missing.

The problem was tracked by Mathias Anselmann in
https://bugzilla.kernel.org/show_bug.cgi?id=219561 and https://gitlab.freedesktop.org/drm/nouveau/-/issues/402

This patch fix the card initialization and fix audio problem on my card GK208B  
the code path is shared by 
nouveau/nvkm/engine/device/base.c- .name = "GK110",
nouveau/nvkm/engine/device/base.c- .name = "GK110B",
nouveau/nvkm/engine/device/base.c- .name = "GK208B",
nouveau/nvkm/engine/device/base.c- .name = "GK208",

I have done another patch so the code don´t broke anymore the initialization if the scdc implementation is missing when supported by the card. It will raise a DBG message instead.


Signed-off-by: Giuseppe Ranieri <giuseppe@ranieri.dev>
---

diff '--color=auto' -ur a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c	2025-11-30 23:42:10.000000000 +0100
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c	2026-01-16 19:03:51.175827296 +0100
@@ -106,6 +106,7 @@
 const struct nvkm_ior_func_hdmi
 gk104_sor_hdmi = {
 	.ctrl = gk104_sor_hdmi_ctrl,
+	.scdc = gm200_sor_hdmi_scdc,
 	.infoframe_avi = gk104_sor_hdmi_infoframe_avi,
 	.infoframe_vsi = gk104_sor_hdmi_infoframe_vsi,
 };
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix scdc implementation missing in GK208B NVidia Card (gk104_sor_hdmi)
  2026-01-17 14:15 [PATCH] Fix scdc implementation missing in GK208B NVidia Card (gk104_sor_hdmi) Giuseppe Ranieri
@ 2026-01-19  8:12 ` Philipp Stanner
  2026-01-19  9:32   ` Giuseppe Ranieri
  0 siblings, 1 reply; 3+ messages in thread
From: Philipp Stanner @ 2026-01-19  8:12 UTC (permalink / raw)
  To: Giuseppe Ranieri, nouveau

On Sat, 2026-01-17 at 15:15 +0100, Giuseppe Ranieri wrote:
> 
> I fixed a problem for the GK208B NVidia Card (GT710): 
> the initialization was broken my card support scdc channel but the implementation was missing.
> 
> The problem was tracked by Mathias Anselmann in
> https://bugzilla.kernel.org/show_bug.cgi?id=219561 and https://gitlab.freedesktop.org/drm/nouveau/-/issues/402

Those two links should be moved to Closes: tags above your Signed-off-
by tag. See the global git log for inspiration.

> 
> This patch fix the card initialization and fix audio problem on my card GK208B  
> the code path is shared by 
> nouveau/nvkm/engine/device/base.c- .name = "GK110",
> nouveau/nvkm/engine/device/base.c- .name = "GK110B",
> nouveau/nvkm/engine/device/base.c- .name = "GK208B",
> nouveau/nvkm/engine/device/base.c- .name = "GK208",
> 
> I have done another patch so the code don´t broke anymore the initialization if the scdc implementation is missing when supported by the card. It will raise a DBG message instead.

So the other patch is related to this one here? If so, they should be
submitted as a patch series (e.g., `git format-patch --histogram
HEAD~2`).

Also, the commit message could need some grammar improvements ;-)


Greetings,
Philipp

> 
> 
> Signed-off-by: Giuseppe Ranieri <giuseppe@ranieri.dev>
> ---
> 
> diff '--color=auto' -ur a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c	2025-11-30 23:42:10.000000000 +0100
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c	2026-01-16 19:03:51.175827296 +0100
> @@ -106,6 +106,7 @@
>  const struct nvkm_ior_func_hdmi
>  gk104_sor_hdmi = {
>  	.ctrl = gk104_sor_hdmi_ctrl,
> +	.scdc = gm200_sor_hdmi_scdc,
>  	.infoframe_avi = gk104_sor_hdmi_infoframe_avi,
>  	.infoframe_vsi = gk104_sor_hdmi_infoframe_vsi,
>  };
>  
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix scdc implementation missing in GK208B NVidia Card (gk104_sor_hdmi)
  2026-01-19  8:12 ` Philipp Stanner
@ 2026-01-19  9:32   ` Giuseppe Ranieri
  0 siblings, 0 replies; 3+ messages in thread
From: Giuseppe Ranieri @ 2026-01-19  9:32 UTC (permalink / raw)
  To: Philipp Stanner; +Cc: nouveau


Add scdc function to gk104_sor_hdmi
Fix the card initialization on card GK208B, the code path is shared by
 -  "GK110"
 -  "GK110B"
 -  "GK208B"
 -  "GK208"

Fix HDMI audio missing  problem.


Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219561 and
+https://gitlab.freedesktop.org/drm/nouveau/-/issues/402
Signed-off-by: Giuseppe Ranieri <giuseppe@ranieri.dev>
---

diff '--color=auto' -ur a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c	2025-11-30 23:42:10.000000000 +0100
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c	2026-01-16 19:03:51.175827296 +0100
@@ -106,6 +106,7 @@
 const struct nvkm_ior_func_hdmi
 gk104_sor_hdmi = {
 	.ctrl = gk104_sor_hdmi_ctrl,
+	.scdc = gm200_sor_hdmi_scdc,
 	.infoframe_avi = gk104_sor_hdmi_infoframe_avi,
 	.infoframe_vsi = gk104_sor_hdmi_infoframe_vsi,
 };
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-01-19  9:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-17 14:15 [PATCH] Fix scdc implementation missing in GK208B NVidia Card (gk104_sor_hdmi) Giuseppe Ranieri
2026-01-19  8:12 ` Philipp Stanner
2026-01-19  9:32   ` Giuseppe Ranieri

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox